Plugin Directory: Validate empty search submissions#741
Closed
obenland wants to merge 1 commit into
Closed
Conversation
Empty search submissions currently reload the page silently. Restore the search block's native required attribute so browsers show their built-in "Please fill out this field" validation, matching the Theme Directory. Keep stripping the attribute on search result pages, so an empty submission can still clear the current search (the reason it was originally removed in r13345). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty search submissions in the Plugin Directory currently reload the page silently, while the Theme Directory shows the browser's native "Please fill out this field" validation message.
The core search block ships with a
requiredattribute on its input, which the Theme Directory keeps. The Plugin Directory theme strips it infilter_search_block()— deliberately, per r13345, so that submitting an empty form on a search results page can clear the current search.This PR restores the
requiredattribute everywhere except on search result pages (is_search()), so:Fixes https://meta.trac.wordpress.org/ticket/8339
🤖 Generated with Claude Code