Update wp-coding-standards/wpcs to 3.4.1 - #859
Merged
Merged
Conversation
- Bump the constraint from ^2.2 to ^3.4.1 and regenerate composer.lock. - Replace sniffs removed in WPCS 3.0 with their upstreamed PHPCS equivalents: WordPress.CodeAnalysis.EmptyStatement -> Generic.CodeAnalysis.EmptyPHPStatement, and WordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition -> Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition. - Fix new violations surfaced by WPCS 3.x: phpcbf formatting fixes and explicit public visibility on 19 methods. - Silence Universal.NamingConventions.NoReservedKeywordParameterNames: renaming parameters risks breaking PHP 8 named-argument callers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
@MaggieCabrera @bph Could I ask for your help with merging this? I don't seem to have access. Thanks! |
MaggieCabrera
approved these changes
Jul 28, 2026
Member
Author
|
@MaggieCabrera Could you merge the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates off the WPCS 2.x pin. Since this repo's CI runs a full
phpcsscan and the ruleset referenced sniffs removed in WPCS 3.0, this PR is more than a version bump:What changed
^2.2to^3.4.1and regeneratescomposer.lock.WordPress.CodeAnalysis.EmptyStatement→Generic.CodeAnalysis.EmptyPHPStatement, andWordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition→Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition. With the old references, phpcs 3.x refuses to run entirely.lint:phpstays green:phpcbfformatting fixes (47 violations — spacing,dirname()modernization,requirebrackets) and explicitpublicvisibility on 19 methods (behavior-neutral;publicis PHP's default).Universal.NamingConventions.NoReservedKeywordParameterNames(7 warnings): the fix would rename parameters like$string, which risks breaking callers using PHP 8 named arguments — a judgment call left to maintainers.Verification: full
phpcsscan is clean (0 errors, 0 warnings), matching the pre-update baseline.Part of an org-wide sweep to get all repos onto WPCS 3.4.1.
🤖 Generated with Claude Code