WIRE-301: Retire legacy staking attestations

contracts/sysio.msgch/src/sysio.msgch.cpp

@@ -794,8 +794,7 @@ void dispatch_node_owner_reg(const std::vector<char>& data, uint64_t chain_code)
 /// in `evalcons` after a consensus envelope has been unpacked. Dispatch is
 /// best-effort — silently no-ops on unknown / out-of-scope types so the
 /// inbound stream can keep flowing even when the depot hasn't yet wired up
-/// every handler (e.g. the deferred STAKE / UNSTAKE / STAKE_UPDATE staking
-/// lifecycle types).
+/// every handler (for example, STAKE_UPDATE from the separate staking track).
 void dispatch_attestation(name self, uint64_t attestation_id,
                           AttestationType type,
                           const std::vector<char>& data,
@@ -920,8 +919,6 @@ void dispatch_attestation(name self, uint64_t attestation_id,
          // opening a sysio.chalg dispute vote, not by inbound challenge attestations.
          break;
 
-      case AttestationType::ATTESTATION_TYPE_STAKE:
-      case AttestationType::ATTESTATION_TYPE_UNSTAKE:
       case AttestationType::ATTESTATION_TYPE_STAKE_UPDATE:
       case AttestationType::ATTESTATION_TYPE_STAKE_RESULT:
          // Validator-staking lifecycle; depot-side handlers land in a later

contracts/sysio.msgch/sysio.msgch.abi

@@ -582,14 +582,6 @@
                     "name": "ATTESTATION_TYPE_OPERATOR_ACTION",
                     "value": 2001
                 },
-                {
-                    "name": "ATTESTATION_TYPE_STAKE",
-                    "value": 3001
-                },
-                {
-                    "name": "ATTESTATION_TYPE_UNSTAKE",
-                    "value": 3002
-                },
                 {
                     "name": "ATTESTATION_TYPE_PRETOKEN_PURCHASE",
                     "value": 3004

contracts/sysio.opp.common/include/sysio.opp.common/opp_table_types.hpp

@@ -298,16 +298,6 @@ DataStream& operator>>(DataStream& ds, ReserveBalanceSheet& t) {
    return ds >> t.chain_code >> t.reserves;
 }
 
-// PretokenStakeChange (deprecated; pre-launch only)
-template <typename DataStream>
-DataStream& operator<<(DataStream& ds, const PretokenStakeChange& t) {
-   return ds << t.actor << t.amount << t.index_at_mint << t.index_at_burn;
-}
-template <typename DataStream>
-DataStream& operator>>(DataStream& ds, PretokenStakeChange& t) {
-   return ds >> t.actor >> t.amount >> t.index_at_mint >> t.index_at_burn;
-}
-
 // PretokenPurchase (deprecated; pre-launch only)
 template <typename DataStream>
 DataStream& operator<<(DataStream& ds, const PretokenPurchase& t) {

contracts/sysio.uwrit/sysio.uwrit.abi

@@ -750,14 +750,6 @@
                     "name": "ATTESTATION_TYPE_OPERATOR_ACTION",
                     "value": 2001
                 },
-                {
-                    "name": "ATTESTATION_TYPE_STAKE",
-                    "value": 3001
-                },
-                {
-                    "name": "ATTESTATION_TYPE_UNSTAKE",
-                    "value": 3002
-                },
                 {
                     "name": "ATTESTATION_TYPE_PRETOKEN_PURCHASE",
                     "value": 3004

contracts/tests/sysio.dispatch_tests.cpp

@@ -187,18 +187,19 @@ std::vector<char> encode_envelope_with_attestations(
 constexpr size_t MAX_ENVELOPE_BYTES = 32'768;
 
 /// Encode a decodable envelope whose serialised size is EXACTLY `target_bytes`, padded with a
-/// single out-of-scope STAKE attestation (dispatch drops it with no value-bearing effect). Probe
-/// once with `target_bytes` of padding to measure the fixed protobuf overhead, then rebuild with
+/// permanently inert processing-error attestation (dispatch drops it with no value-bearing effect).
+/// Probe once with `target_bytes` of padding to measure the fixed protobuf overhead, then rebuild with
 /// the pad shrunk by that overhead: at sizes near the 32 KiB envelope cap every nested length
 /// prefix and the `data_size` varint sit in the same 3-byte width band (16 KiB .. 2 MiB), so the
 /// second pass lands exactly on target — the final REQUIRE pins it.
 std::vector<char> encode_envelope_padded_to(uint32_t epoch_index, size_t target_bytes) {
    auto probe = encode_envelope_with_one_attestation(
-      epoch_index, sysio::opp::types::ATTESTATION_TYPE_STAKE, std::string(target_bytes, 'x'));
+      epoch_index, sysio::opp::types::ATTESTATION_TYPE_ATTESTATION_PROCESSING_ERROR,
+      std::string(target_bytes, 'x'));
    BOOST_REQUIRE_GT(probe.size(), target_bytes);
    const size_t overhead = probe.size() - target_bytes;
    auto padded = encode_envelope_with_one_attestation(
-      epoch_index, sysio::opp::types::ATTESTATION_TYPE_STAKE,
+      epoch_index, sysio::opp::types::ATTESTATION_TYPE_ATTESTATION_PROCESSING_ERROR,
       std::string(target_bytes - overhead, 'x'));
    BOOST_REQUIRE_EQUAL(target_bytes, padded.size());
    return padded;
@@ -1468,7 +1469,7 @@ BOOST_FIXTURE_TEST_CASE(dispatch_silently_drops_out_of_scope_types, sysio_dispat
    const auto eth_code = fc::slug_name{"ETH"}.value;
    auto envelope = encode_envelope_with_one_attestation(
       current_epoch(),
-      sysio::opp::types::ATTESTATION_TYPE_STAKE,
+      sysio::opp::types::ATTESTATION_TYPE_ATTESTATION_PROCESSING_ERROR,
       std::string{});
 
    BOOST_REQUIRE_EQUAL(success(), deliver(/*chain_code=*/eth_code, envelope));
@@ -1863,7 +1864,7 @@ BOOST_FIXTURE_TEST_CASE(deliver_duplicate_from_same_operator_reverts, sysio_disp
    const auto eth_code = fc::slug_name{"ETH"}.value;
    auto envelope = encode_envelope_with_one_attestation(
       current_epoch(),
-      sysio::opp::types::ATTESTATION_TYPE_STAKE,
+      sysio::opp::types::ATTESTATION_TYPE_ATTESTATION_PROCESSING_ERROR,
       std::string{});
 
    BOOST_REQUIRE_EQUAL(success(), deliver(/*chain_code=*/eth_code, envelope));

contracts/tests/sysio.msgch_chain_tests.cpp

@@ -445,12 +445,12 @@ class sysio_msgch_chain_tester : public tester {
 
    // -- Inbound envelope builder --
 
-   /// Encode a deliverable envelope carrying one out-of-scope STAKE attestation (dispatch drops
-   /// the attestation silently; acceptance is still fully observable via `outpcons` and the
-   /// stored attestation row). The semantic header is derived per the spec — `apply_consensus`
+   /// Encode a deliverable envelope carrying one permanently inert processing-error attestation.
+   /// Dispatch drops the attestation silently; acceptance is still fully observable via `outpcons`
+   /// and the stored attestation row. The semantic header is derived per the spec — `apply_consensus`
    /// drops envelopes whose header fields do not recompute or whose message does not continue the
-   /// per-outpost message chain. `prev` (previous_envelope_hash), `prev_message_id`, and
-   /// `env_hash` are raw 32-byte strings (or empty for stream genesis).
+   /// per-outpost message chain. `prev` (previous_envelope_hash), `prev_message_id`, and `env_hash`
+   /// are raw 32-byte strings (or empty for stream genesis).
    std::vector<char> encode_delivery(uint32_t epoch_index, const std::string& att_data,
                                      const std::string& prev = {},
                                      const std::string& prev_message_id = {},
@@ -462,7 +462,7 @@ class sysio_msgch_chain_tester : public tester {
       if (!prev.empty()) env.set_previous_envelope_hash(prev);
       if (!env_hash.empty()) env.set_envelope_hash(env_hash);
       auto* att = env.add_messages()->mutable_payload()->add_attestations();
-      att->set_type(sysio::opp::types::ATTESTATION_TYPE_STAKE);
+      att->set_type(sysio::opp::types::ATTESTATION_TYPE_ATTESTATION_PROCESSING_ERROR);
       att->set_data(att_data);
       att->set_data_size(static_cast<uint32_t>(att_data.size()));
       oracle::finalize_header(*env.mutable_messages(0), prev_message_id, 1'775'612'516'983ULL);

etc/schema/opp_entity_diagram-gen.puml

@@ -44,11 +44,6 @@ sysio.opp.MessagePayload -- sysio.opp.AttestationEntry
 
 
 
-sysio.opp.attestations.PretokenStakeChange -- sysio.opp.types.ChainAddress
-sysio.opp.attestations.PretokenStakeChange -- sysio.opp.types.TokenAmount
-
-
-
 sysio.opp.types.ChainSignature -- sysio.opp.types.ChainAddress
 sysio.opp.types.ChainSignature -- sysio.opp.types.ChainKeyType
 
@@ -109,13 +104,6 @@ package sysio.opp.attestations {
   index_at_mint: Long
  }
 
- class PretokenStakeChange {
-  actor: sysio.opp.types.ChainAddress
-  amount: sysio.opp.types.TokenAmount
-  index_at_mint: Long
-  index_at_burn: Long
- }
-
  class PretokenYield {
   actor: sysio.opp.types.ChainAddress
   amount: sysio.opp.types.TokenAmount
@@ -156,8 +144,6 @@ package sysio.opp.attestations {
 package sysio.opp.types {
  enum AttestationType {
   ATTESTATION_TYPE_UNSPECIFIED
-  ATTESTATION_TYPE_STAKE
-  ATTESTATION_TYPE_UNSTAKE
   ATTESTATION_TYPE_PRETOKEN_PURCHASE
   ATTESTATION_TYPE_PRETOKEN_YIELD
   ATTESTATION_TYPE_RESERVE_BALANCE_SHEET

etc/schema/opp_entity_diagram.puml

@@ -51,8 +51,6 @@ package opp.types #F5F5F5 {
 
     enum attestation_type_t <<uint16>> {
         reserve_balance_sheet = 0xAA00
-        stake               = 0x0BB9
-        unstake             = 0x0BBA
         pretoken_purchase   = 0x0BBB
         pretoken_yield      = 0x0BBE
         --
@@ -149,21 +147,6 @@ package opp.attestations #FCE4EC {
         * amounts  : token_amount[]
     }
 
-    entity stake {
-        * actor      : chain_address
-        * amount               : token_amount
-        * pretoken_count           : uint256
-        * index_at_mint : uint256
-    }
-
-    entity unstake {
-        * unstaker      : chain_address
-        * amount               : token_amount
-        * pretoken_count           : uint256
-        * index_at_burn    : uint256
-
-    }
-
     entity pretoken_purchase {
         * actor             : chain_address
         * amount            : token_amount
@@ -249,8 +232,6 @@ package opp.attestations #FCE4EC {
 
 ' -- Assertion entry resolves to concrete payloads --
 opp.attestation_entry ..> opp.attestations.reserve_balance_sheet
-opp.attestation_entry ..> opp.attestations.stake
-opp.attestation_entry ..> opp.attestations.unstake
 opp.attestation_entry ..> opp.attestations.pretoken_purchase
 opp.attestation_entry ..> opp.attestations.pretoken_yield
 opp.attestation_entry ..> opp.attestations.stake_update

libraries/opp/include/sysio/opp/opp.hpp

@@ -82,8 +82,6 @@ FC_REFLECT_ENUM(sysio::opp::types::ReserveStatus,
 FC_REFLECT_ENUM(sysio::opp::types::AttestationType,
    (ATTESTATION_TYPE_UNSPECIFIED)
    (ATTESTATION_TYPE_OPERATOR_ACTION)
-   (ATTESTATION_TYPE_STAKE)
-   (ATTESTATION_TYPE_UNSTAKE)
    (ATTESTATION_TYPE_PRETOKEN_PURCHASE)
    (ATTESTATION_TYPE_PRETOKEN_YIELD)
    (ATTESTATION_TYPE_RESERVE_BALANCE_SHEET)

libraries/opp/proto/sysio/opp/attestations/attestations.proto

@@ -34,13 +34,6 @@ message ReserveBalanceSheet {
 //  during the deprecation pass)
 // ---------------------------------------------------------------------------
 
-message PretokenStakeChange {
-  sysio.opp.types.ChainAddress actor          = 1;
-  sysio.opp.types.TokenAmount  amount         = 2;
-  int64                        index_at_mint  = 10;
-  int64                        index_at_burn  = 11;
-}
-
 message PretokenPurchase {
   sysio.opp.types.ChainAddress actor          = 1;
   sysio.opp.types.TokenAmount  amount         = 2;

libraries/opp/proto/sysio/opp/types/types.proto

@@ -229,10 +229,13 @@ message ReserveAmount {
 // ---------------------------------------------------------------------------
 
 enum AttestationType {
+  reserved 3001, 3002;
+  reserved "ATTESTATION_TYPE_STAKE", "ATTESTATION_TYPE_UNSTAKE";
+
   ATTESTATION_TYPE_UNSPECIFIED = 0;
   ATTESTATION_TYPE_OPERATOR_ACTION = 2001; // 0x07D1
-  ATTESTATION_TYPE_STAKE = 3001;
-  ATTESTATION_TYPE_UNSTAKE = 3002;
+  // 3001 was ATTESTATION_TYPE_STAKE — removed; do not reuse.
+  // 3002 was ATTESTATION_TYPE_UNSTAKE — removed; do not reuse.
   // DEPRECATED — pre-launch only, do not use in new code.
   ATTESTATION_TYPE_PRETOKEN_PURCHASE = 3004;
   // DEPRECATED — pre-launch only, do not use in new code.