Repository navigation
fix: update Node.js and Bun for CVE-2026-111497 and enable Renovate - #33
Merged
Merged
Conversation
Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
`.then((handle) => handle.evaluate(...))` is a tail call that JavaScriptCore eliminates, so under Bun 1.4.4 puppeteer's `withSourcePuppeteerURLIfNone` finds no third stack frame and throws `undefined is not an object (evaluating 'site.toString')`. Awaiting the handle first keeps the judge's own frame on the stack. Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Changes
mise.toml:node24.21.0 → 24.22.1,bun1.4.2 → 1.4.4renovate.jsonc: extendgithub>WillBooster/willbooster-configs:renovate.jsoncexample_course_imported_html_css/judge.ts: await the element handle before callingevaluateinstead of.then((handle) => handle.evaluate(...))Why the judge changes
Under Bun 1.4.4 the HTML/CSS judge failed with
undefined is not an object (evaluating 'site.toString'). puppeteer-core'swithSourcePuppeteerURLIfNonereads the third frame of a structured stack trace (stack[2]) unconditionally. The.thenarrow is a tail call that JavaScriptCore eliminates, so the stack held only puppeteer's own frames; Bun 1.4.2 happened to append a nativeprocessTicksAndRejectionsframe there, which Bun 1.4.4 no longer does on this path. Awaiting the handle first keeps the judge's own frame on the stack.Verification
bun run testpasses locally on both Bun 1.4.4 and 1.4.2, and CI passes.