Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #399 +/- ##
============================================
- Coverage 91.19% 91.07% -0.13%
- Complexity 5611 5623 +12
============================================
Files 609 610 +1
Lines 14793 14839 +46
Branches 1382 1387 +5
============================================
+ Hits 13491 13515 +24
- Misses 1267 1289 +22
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ST 2101 is way to embed the MIIS Core Identifier into the video frame (i.e. SEI message, rather than KLV metadata elementary stream), mainly intended to handle the case where video and metadata get partitioned (e.g. for a HLS/DASH/CMAF encoding).
We have an open task (#273) to add support for that, and it is partly completed. This provides the remaining work.
Description
Adds selective coding (e.g. this doesn't appear to play well with x265 encoder in ffmpeg), and viewer support to display it over in the metadata tree.
I'm not entirely sure about the viewer support. It seems like a hack because of the metadata vs video interfaces. On the other hand, it is handy to see the information in the same way in the same area.
How Has This Been Tested?
Unit tests.
Generated sample data using generator example, viewed it in the viewer.
Screenshots (if appropriate):
Note new MIIS entry in lower right:
That also works for the ST 0604 SEI message, although this test sample doesn't have ST 2101 data:
Types of changes
Checklist: