bug fix - #3
Open
shelcia wants to merge 1 commit into
Open
Conversation
Zaid-maker
suggested changes
Jun 2, 2021
Zaid-maker
left a comment
Zaid-maker
left a comment
There was a problem hiding this comment.
Doesnot work for me please provide a snipet
Author
|
you can find it easily in the commit. I have changed within the useLocalStorage.js |
|
Anything about hosting that app |
Author
|
Yes !! I have deployed after learning this. You can look in this repo https://github.com/shelcia/ChatApp. In this you will find the backend and frontend deployment. I used Netlify and Heroku |
|
same her i also use netlify and heroku
…On Tue, 8 Jun 2021 at 15:42, shelcia ***@***.***> wrote:
Yes !! I have deployed after learning this. You can look in this repo
https://github.com/shelcia/ChatApp. In this you will find the backend and
frontend deployment. I used Netlify and Heroku
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMXTCNCRGNAZLGRXBMBJDLDTRXXYFANCNFSM4SGTLVGA>
.
|
|
that's totally unbelieveable
…On Wed, 9 Jun 2021 at 14:03, Mirza Zaid Hafeez ***@***.***> wrote:
same her i also use netlify and heroku
On Tue, 8 Jun 2021 at 15:42, shelcia ***@***.***> wrote:
> Yes !! I have deployed after learning this. You can look in this repo
> https://github.com/shelcia/ChatApp. In this you will find the backend
> and frontend deployment. I used Netlify and Heroku
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#3 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMXTCNCRGNAZLGRXBMBJDLDTRXXYFANCNFSM4SGTLVGA>
> .
>
|
|
https://github.com/Zaid-maker/cyclone-messaging
can u please check
… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey !! When the user reloads the login page it showed a cross-origin error. So i figured out that it was due to custom hook which sets it value from local storage. When the window is opened the variable is being stored but has the value undefined. So when the user and tries to get data the error case of value undefined is not handled in useLocalStorage hook. I hope it helps. I have learnt from you ;). Keep making awesome clone videos