Open
Conversation
Including both atomic get/set operations and RMWs.
kripken
approved these changes
Mar 30, 2026
| auto check = makeArrayBoundsCheck(ref, index, funcContext->func, builder); | ||
| auto* rmw = | ||
| builder.makeArrayRMW(op, check.getRef, check.getIndex, value, order); | ||
| auto* fallback = makeTrivial(type); |
Member
There was a problem hiding this comment.
Why is this trivial? It could be anything?
Member
Author
There was a problem hiding this comment.
This is the same pattern we already use for array.get. I guess it's trivial to reduce the amount of code we generate beyond the requested array operation? Other non-trivial things can already be generated by other means. I'd be happy to update both locations if you think it would be better, though.
Member
There was a problem hiding this comment.
Oh, right, I guess it's just for the fallback, if the bounds check fails. Something trivial is good enough there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including both atomic get/set operations and RMWs.