fix: resolve #1270, #1269, #1378, #1377 with comprehensive contract t…

nevo_contract/contracts/hello-world/src/lib.rs

@@ -622,6 +622,14 @@ impl Contract {
         pool.collected
     }
 
+    /// Get the campaign balance (total amount raised) for a pool.
+    ///
+    /// Issue #1269: Returns the total collected donation balance for the specified campaign.
+    /// Panics with `ContractError::PoolNotFound` if the campaign does not exist.
+    pub fn get_campaign_balance(env: Env, pool_id: u32) -> u128 {
+        Self::get_total_raised(env, pool_id)
+    }
+
     /// Get the ledger timestamp of the most recent contribution to a pool.
     /// Returns 0 if the pool has never received a donation.
     pub fn get_last_donation_at(env: Env, pool_id: u32) -> u64 {

nevo_contract/contracts/hello-world/src/test_campaign_balance.rs

@@ -1,5 +1,5 @@
 #![cfg(test)]
-//! Tests for `get_campaign_balance` edge cases — issue #1061.
+//! Tests for `get_campaign_balance` edge cases — issue #1269 (and #1061).
 //!
 //! Covers:
 //!   1. New campaign returns 0 balance.
@@ -104,6 +104,22 @@ fn test_campaign_balance_nonexistent_campaign_returns_not_found() {
     let _ = client.get_campaign_balance(&9999u32);
 }
 
+/// Calling `try_get_campaign_balance` with a nonexistent campaign ID returns
+/// `ContractError::PoolNotFound` error variant.
+#[test]
+fn test_campaign_balance_nonexistent_campaign_try_returns_not_found() {
+    let env = Env::default();
+    let contract_id = env.register(Contract, ());
+    let client = ContractClient::new(&env, &contract_id);
+
+    let res = client.try_get_campaign_balance(&9999u32);
+    assert_eq!(
+        res,
+        Err(Ok(ContractError::PoolNotFound)),
+        "Nonexistent campaign must return ContractError::PoolNotFound"
+    );
+}
+
 // ── Test 4: balance equals mathematical sum of all donations ─────────────
 
 /// The stored campaign balance must equal the exact arithmetic sum of every

nevo_contract/contracts/hello-world/src/test_issue_1270_campaign_contribution.rs

@@ -0,0 +1,168 @@
+#![cfg(test)]
+//! Tests for campaign contribution getter validation — issue #1270.
+//!
+//! Covers `get_contribution` function:
+//!   (1) Contributor with no donations returns 0.
+//!   (2) Contributor with multiple donations returns sum.
+//!   (3) Nonexistent contributor returns 0.
+//!   (4) Nonexistent campaign returns CampaignNotFound (PoolNotFound / Error #1).
+//!   (5) Multiple contributors tracked separately.
+
+use super::*;
+use soroban_sdk::{testutils::Address as _, Address, Env, String};
+
+// ── Helpers ─────────────────────────────────────────────────────────────────
+
+fn setup_pool(env: &Env, client: &ContractClient) -> (u32, Address) {
+    let creator = Address::generate(env);
+    let pool_id = client.create_pool(
+        &creator,
+        &String::from_str(env, "Contribution Validation Pool"),
+        &String::from_str(env, "Tests for get_contribution getter validation"),
+        &10_000_000_000u128,
+        &100_000u64,
+    );
+    (pool_id, creator)
+}
+
+// ── Test 1: Contributor with no donations returns 0 ─────────────────────────
+
+#[test]
+fn test_contributor_with_no_donations_returns_zero() {
+    let env = Env::default();
+    let contract_id = env.register(Contract, ());
+    let client = ContractClient::new(&env, &contract_id);
+
+    let (pool_id, _) = setup_pool(&env, &client);
+    let contributor = Address::generate(&env);
+
+    assert_eq!(
+        client.get_contribution(&pool_id, &contributor),
+        0u128,
+        "A contributor with no recorded donations must return 0"
+    );
+}
+
+// ── Test 2: Contributor with multiple donations returns sum ─────────────────
+
+#[test]
+fn test_contributor_with_multiple_donations_returns_sum() {
+    let env = Env::default();
+    let contract_id = env.register(Contract, ());
+    let client = ContractClient::new(&env, &contract_id);
+
+    let (pool_id, _) = setup_pool(&env, &client);
+    let contributor = Address::generate(&env);
+
+    let donation1 = 100_000_000u128;
+    let donation2 = 250_000_000u128;
+    let donation3 = 450_000_000u128;
+
+    client.donate(&pool_id, &contributor, &donation1);
+    assert_eq!(client.get_contribution(&pool_id, &contributor), donation1);
+
+    client.donate(&pool_id, &contributor, &donation2);
+    assert_eq!(
+        client.get_contribution(&pool_id, &contributor),
+        donation1 + donation2
+    );
+
+    client.donate(&pool_id, &contributor, &donation3);
+    assert_eq!(
+        client.get_contribution(&pool_id, &contributor),
+        donation1 + donation2 + donation3,
+        "Accumulated donations from a single contributor must equal their exact sum"
+    );
+}
+
+// ── Test 3: Nonexistent contributor returns 0 ───────────────────────────────
+
+#[test]
+fn test_nonexistent_contributor_returns_zero() {
+    let env = Env::default();
+    let contract_id = env.register(Contract, ());
+    let client = ContractClient::new(&env, &contract_id);
+
+    let (pool_id, _) = setup_pool(&env, &client);
+
+    // Active contributor makes a donation
+    let active_contributor = Address::generate(&env);
+    client.donate(&pool_id, &active_contributor, &1_000_000_000u128);
+
+    // Nonexistent contributor who never interacted with the contract
+    let nonexistent_contributor = Address::generate(&env);
+    assert_eq!(
+        client.get_contribution(&pool_id, &nonexistent_contributor),
+        0u128,
+        "A contributor who has never interacted with the pool must return 0"
+    );
+}
+
+// ── Test 4: Nonexistent campaign returns CampaignNotFound ───────────────────
+
+#[test]
+#[should_panic(expected = "Error(Contract, #1)")]
+fn test_nonexistent_campaign_returns_campaign_not_found_panic() {
+    let env = Env::default();
+    let contract_id = env.register(Contract, ());
+    let client = ContractClient::new(&env, &contract_id);
+
+    let contributor = Address::generate(&env);
+    let _ = client.get_contribution(&9999u32, &contributor);
+}
+
+#[test]
+fn test_nonexistent_campaign_returns_campaign_not_found_result() {
+    let env = Env::default();
+    let contract_id = env.register(Contract, ());
+    let client = ContractClient::new(&env, &contract_id);
+
+    let contributor = Address::generate(&env);
+    let result = client.try_get_contribution(&9999u32, &contributor);
+    assert_eq!(
+        result,
+        Err(Ok(ContractError::PoolNotFound)),
+        "Nonexistent campaign must return ContractError::PoolNotFound"
+    );
+}
+
+// ── Test 5: Multiple contributors tracked separately ────────────────────────
+
+#[test]
+fn test_multiple_contributors_tracked_separately() {
+    let env = Env::default();
+    let contract_id = env.register(Contract, ());
+    let client = ContractClient::new(&env, &contract_id);
+
+    let (pool_id, _) = setup_pool(&env, &client);
+
+    let contributor_a = Address::generate(&env);
+    let contributor_b = Address::generate(&env);
+    let contributor_c = Address::generate(&env);
+
+    let amount_a1 = 150_000_000u128;
+    let amount_b = 300_000_000u128;
+    let amount_a2 = 50_000_000u128;
+    let amount_c = 750_000_000u128;
+
+    client.donate(&pool_id, &contributor_a, &amount_a1);
+    client.donate(&pool_id, &contributor_b, &amount_b);
+    client.donate(&pool_id, &contributor_a, &amount_a2);
+    client.donate(&pool_id, &contributor_c, &amount_c);
+
+    assert_eq!(
+        client.get_contribution(&pool_id, &contributor_a),
+        amount_a1 + amount_a2,
+        "Contributor A's total must be tracked independently"
+    );
+    assert_eq!(
+        client.get_contribution(&pool_id, &contributor_b),
+        amount_b,
+        "Contributor B's total must be tracked independently"
+    );
+    assert_eq!(
+        client.get_contribution(&pool_id, &contributor_c),
+        amount_c,
+        "Contributor C's total must be tracked independently"
+    );
+}