Repository navigation
vtselect: return 404 for Tempo /api/v2/traces/diff - #315
Open
mastersans wants to merge 1 commit into
Open
mastersans wants to merge 1 commit into
mastersans wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
The v2 trace-by-ID prefix treated diff as a trace ID and scanned storage. Signed-off-by: Sanskar Sharma <sanskarsharma3110@gmail.com>
mastersans
force-pushed
the
fix-tempo-traces-diff
branch
from
November 11, 2026 18:31
dc5a01a to
6b9c66f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GETandPOST /select/tempo/api/v2/traces/diffnow return 404 without searching storage. The/select/tempo/api/v2/traces/prefix treateddiffas a trace ID, scanned the retention period, and returned 200 with an empty trace.On a separate note Tempo's trace-diff API is still not implemented. I will be happy to help with implementing it?
Test plan
GETandPOST /select/tempo/api/v2/traces/diffreturn 404, includingPOSTwithstartandend/select/tempo/api/v2/traces/{trace_id}lookup still returns the trace