fix: deposit state of Pendle vaults#5624
Conversation
🦋 Changeset detectedLatest commit: f507ef0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR fixes an incorrect vault status for Pendle vaults that have an existing supply balance and are still pre-maturity — they were previously labelled
Confidence Score: 4/5Safe to merge once the changeset bump type is corrected; the functional fix is straightforward and well-tested. The changeset is tagged minor for what is clearly a bug fix, which would produce an unintended minor version bump for the @venusprotocol/evm package. The core logic change is correct and covered by updated tests; a redundant else-if branch is a minor cleanup opportunity but does not affect behavior. .changeset/swift-beans-say.md — the bump type should be patch rather than minor. Important Files Changed
Reviews (1): Last reviewed commit: "fix: deposit state of Pendle vaults" | Re-trigger Greptile |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@venusprotocol/evm": minor | |||
There was a problem hiding this comment.
Changeset bump type should be
patch, not minor
This change corrects an incorrect vault status being emitted — that's a bug fix, which maps to a patch version bump under semantic versioning. Using minor implies new additive functionality and would unnecessarily bump the minor version for downstream consumers of the @venusprotocol/evm package.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Coverage Report for ./apps/evm
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Changes