Skip to content

fix: deposit state of Pendle vaults#5624

Merged
therealemjy merged 1 commit into
mainfrom
fix/pendle-supply
Jun 10, 2026
Merged

fix: deposit state of Pendle vaults#5624
therealemjy merged 1 commit into
mainfrom
fix/pendle-supply

Conversation

@therealemjy

Copy link
Copy Markdown
Member

Changes

  • fix deposit state of Pendle vaults

@therealemjy therealemjy requested a review from cuzz-venus June 10, 2026 08:23
@changeset-bot

changeset-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f507ef0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview Jun 10, 2026 8:25am
dapp-testnet Ready Ready Preview Jun 10, 2026 8:25am
venus.io Ready Ready Preview Jun 10, 2026 8:25am

Request Review

@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes an incorrect vault status for Pendle vaults that have an existing supply balance and are still pre-maturity — they were previously labelled Locked but should show Deposit. It also adds a distinct maturityDatePendle translation key so the vault card and modal display "Maturity date" for Pendle vaults rather than the generic "Lock end date".

  • Status fix: formatToPendleVault now correctly keeps VaultStatus.Deposit (the default) for pre-maturity positions; a now-redundant else if branch that re-assigned the same value is left in place.
  • Label differentiation: New maturityDatePendle i18n key added across all 7 locale files; both VaultCard and the Pendle modal footer consume the new key for Pendle vaults.
  • Changeset: Marked as minor but the change is a bug fix; patch would be the correct bump type.

Confidence Score: 4/5

Safe to merge once the changeset bump type is corrected; the functional fix is straightforward and well-tested.

The changeset is tagged minor for what is clearly a bug fix, which would produce an unintended minor version bump for the @venusprotocol/evm package. The core logic change is correct and covered by updated tests; a redundant else-if branch is a minor cleanup opportunity but does not affect behavior.

.changeset/swift-beans-say.md — the bump type should be patch rather than minor.

Important Files Changed

Filename Overview
apps/evm/src/clients/api/queries/useGetVaults/useGetFormattedFixedRatedVaults/formatVaults/formatToPendleVault/index.tsx Core fix: status now defaults to Deposit instead of Locked for pre-maturity Pendle vaults with existing supply balance; the else-if branch that sets Deposit is now redundant dead code.
.changeset/swift-beans-say.md Changeset incorrectly marks this bug fix as minor instead of patch.
apps/evm/src/containers/VaultCard/index.tsx Label for maturity date on vault card now conditionally shows "Maturity date" for Pendle vaults vs "Lock end date" for others.
apps/evm/src/containers/VaultCard/PendleVaultModal/PositionTab/Footer/index.tsx Modal footer label updated to use maturityDatePendle translation key instead of the generic maturityDate.
apps/evm/src/libs/translations/translations/en.json Added maturityDatePendle: "Maturity date" key in both vault.card and vault.modals namespaces to distinguish Pendle-specific label from the generic "Lock end date".

Reviews (1): Last reviewed commit: "fix: deposit state of Pendle vaults" | Re-trigger Greptile

@@ -0,0 +1,5 @@
---
"@venusprotocol/evm": minor

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Changeset bump type should be patch, not minor

This change corrects an incorrect vault status being emitted — that's a bug fix, which maps to a patch version bump under semantic versioning. Using minor implies new additive functionality and would unnecessarily bump the minor version for downstream consumers of the @venusprotocol/evm package.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 81.53% 47359 / 58087
🔵 Statements 81.53% 47359 / 58087
🔵 Functions 62.46% 654 / 1047
🔵 Branches 73% 5399 / 7395
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/clients/api/queries/useGetVaults/useGetFormattedFixedRatedVaults/formatVaults/formatToPendleVault/index.tsx 97.53% 81.81% 100% 97.53% 1, 100
apps/evm/src/containers/VaultCard/index.tsx 76.68% 69.76% 0% 76.68% 52-56, 59-61, 65, 94-96, 120-139, 210-227, 256-261, 267-270
apps/evm/src/containers/VaultCard/PendleVaultModal/PositionTab/Footer/index.tsx 100% 90% 100% 100%
Generated in workflow #13586 for commit f507ef0 by the Vitest Coverage Report Action

@cuzz-venus cuzz-venus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@therealemjy therealemjy merged commit e440ad3 into main Jun 10, 2026
5 checks passed
@therealemjy therealemjy deleted the fix/pendle-supply branch June 10, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants