Skip to content

Remove duplicate FastPass seeding in main seeder pipeline#15

Merged
lucas-luchack merged 3 commits into
mainfrom
copilot/remove-duplicate-fastpassseeder-call
Jul 24, 2026
Merged

Remove duplicate FastPass seeding in main seeder pipeline#15
lucas-luchack merged 3 commits into
mainfrom
copilot/remove-duplicate-fastpassseeder-call

Conversation

Copilot AI commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

FastPassSeeder was executed twice in main_seeder.ts, causing duplicate FastPass records during database seeding. This PR removes the redundant invocation so the seeding order remains intact while ensuring FastPass data is inserted once.

  • What changed

    • Removed the second FastPassSeeder call from the step-3 seeder block in database/seeders/main_seeder.ts.
    • Kept the existing step-2 FastPassSeeder execution unchanged.
  • Why this matters

    • Prevents duplicate inserts for FastPass seed data.
    • Preserves current seeder dependency flow and execution sequence for all other seeders.
// before
await this.runSeeder(FastPassSeeder) // step 2
...
await this.runSeeder(FastPassSeeder) // step 3 (duplicate)

// after
await this.runSeeder(FastPassSeeder) // step 2 only
Original prompt
Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"FastPassSeeder is run twice - once on line 42 and again on line 48. This will cause duplicate data insertion. Remove one of the duplicate calls.","fixFiles":[{"filePath":"database/seeders/main_seeder.ts","diff":"diff --git a/database/seeders/main_seeder.ts b/database/seeders/main_seeder.ts\n--- a/database/seeders/main_seeder.ts\n+++ b/database/seeders/main_seeder.ts\n@@ -45,7 +45,6 @@\n     await this.runSeeder(ProductSeeder)\n     await this.runSeeder(RestockSeeder)\n     await this.runSeeder(LogSeeder)\n-    await this.runSeeder(FastPassSeeder)\n \n     // 4. Seeders dépendants des seeders précédents\n     await this.runSeeder(SubscriptionSeeder)\n"}]}]

Copilot AI changed the title [WIP] Fix duplicate FastPassSeeder call in main seeder Remove duplicate FastPass seeding in main seeder pipeline Jul 9, 2026
Copilot AI requested a review from lucas-luchack July 9, 2026 11:18
@ThibaultLatxague

Copy link
Copy Markdown
Collaborator

Bah alors tu donnes pas ton review à Copilot @lucas-luchack ??

Copilot AI review requested due to automatic review settings July 24, 2026 19:59
@lucas-luchack
lucas-luchack marked this pull request as ready for review July 24, 2026 19:59
@gitguardian

gitguardian Bot commented Jul 24, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
28946910 Triggered Generic Password 413c5c2 .github/workflows/ci.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@lucas-luchack
lucas-luchack enabled auto-merge July 24, 2026 19:59
@lucas-luchack
lucas-luchack disabled auto-merge July 24, 2026 19:59
@github-actions

Copy link
Copy Markdown

Version Preview

Current version v0.6.0
Next version v0.6.1
Bump type patch

To override the bump type, add a label: major, minor, or patch
Or use conventional commits: feat: → minor, fix: → patch, BREAKING CHANGE → major

@lucas-luchack
lucas-luchack merged commit 7f08cb7 into main Jul 24, 2026
4 of 5 checks passed
@lucas-luchack
lucas-luchack deleted the copilot/remove-duplicate-fastpassseeder-call branch July 24, 2026 19:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a redundant FastPassSeeder invocation from the main database seeding pipeline so FastPass seed data is inserted exactly once while preserving the existing seeder execution order.

Changes:

  • Deleted the duplicate await this.runSeeder(FastPassSeeder) from the step-3 block in main_seeder.ts.
  • Kept the step-2 FastPassSeeder execution intact, ensuring FastPass remains seeded at the intended stage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants