Remove duplicate FastPass seeding in main seeder pipeline#15
Conversation
|
Bah alors tu donnes pas ton review à Copilot @lucas-luchack ?? |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 28946910 | Triggered | Generic Password | 413c5c2 | .github/workflows/ci.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Version Preview
|
There was a problem hiding this comment.
Pull request overview
Removes a redundant FastPassSeeder invocation from the main database seeding pipeline so FastPass seed data is inserted exactly once while preserving the existing seeder execution order.
Changes:
- Deleted the duplicate
await this.runSeeder(FastPassSeeder)from the step-3 block inmain_seeder.ts. - Kept the step-2
FastPassSeederexecution intact, ensuring FastPass remains seeded at the intended stage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FastPassSeederwas executed twice inmain_seeder.ts, causing duplicate FastPass records during database seeding. This PR removes the redundant invocation so the seeding order remains intact while ensuring FastPass data is inserted once.What changed
FastPassSeedercall from the step-3 seeder block indatabase/seeders/main_seeder.ts.FastPassSeederexecution unchanged.Why this matters
Original prompt