Repository navigation
fix(pm): serialize pm_early_exit_claim_paid (103) and pm_lp_payout (104) vops - #14
Merged
Merged
Conversation
…04) vops C++ pm branch added two virtual operations after pm_dispute_opened (102): pm_early_exit_claim_paid (F1/steemit#300) and pm_lp_payout (goal steemit#442). Without the serializers account_history decoders shift fields on these ops. Pin JS to C++ FC_REFLECT field order and add round-trip tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++
pmbranch added two virtual operations afterpm_dispute_opened(102):pm_early_exit_claim_paid(F1/steemit#300) andpm_lp_payout(steemit#442). Without the serializers, account_history decoders shift fields on these ops.CI:
npm run test-ci— 97 passing locally.