[CURA-13259] Port the 'overhang checker' code over to C++ in an attempt to optimize. - #18
Open
Remco Burema (rburema) wants to merge 10 commits into
Open
[CURA-13259] Port the 'overhang checker' code over to C++ in an attempt to optimize.#18Remco Burema (rburema) wants to merge 10 commits into
Remco Burema (rburema) wants to merge 10 commits into
Conversation
(Current commit:) Seems to work. While it is signigicantly faster, that is not so to the extent that we hoped (seen about 4x to 9x speedup). Propose to further optimize, unless it's the marshalling. CURA-13259
Should be robust against missing (face) indices now. part of CURA-13259
Remco Burema (rburema)
marked this pull request as ready for review
September 10, 2026 07:26
Member
Author
|
It seems face connectivity would give us the added boost we need. However, I don't fully trust it yet -- let's continue with the 'needs-support' part and leave the face connectivity stuff in for later. |
part of CURA-13259 Co-authored-by: Erwan Mathieu <erwan.mathieu@ultimaker.com>
Erwan MATHIEU (wawanbreton)
approved these changes
Sep 10, 2026
Erwan MATHIEU (wawanbreton)
left a comment
Erwan MATHIEU (wawanbreton)
left a comment
Contributor
There was a problem hiding this comment.
Comments done live and processed, LGTM !
CURA-13259 This allows leveraging the array structure, and simplifies some pieces of code
CURA-13259 This allows leveraging the array structure, and simplifies some pieces of code
CURA-13259
Co-authored-by: wawanbreton <601114+wawanbreton@users.noreply.github.com>
CURA-13259
CURA-13259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Current commit:) Seems to work. While it is signigicantly faster, that is not so to the extent that we hoped (seen about 4x to 9x speedup). Propose to further optimize, unless it's the marshalling.