Value correction - #21792
Open
HellAholic wants to merge 1 commit into
Open
Value correction#21792HellAholic wants to merge 1 commit into
HellAholic wants to merge 1 commit into
Conversation
The setting is not settable per mesh based on the engine implementation.
Contributor
Test Results24 955 tests 24 953 ✅ 51s ⏱️ Results for commit a8a8f4b. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the
resources/definitions/fdmprinter.def.jsonfile. The change updates thesettable_per_meshproperty for a support setting, making the setting value in line with the engine implementation.settable_per_meshtofalsefor the relevant support setting, preventing users from configuring this parameter on a per-mesh basis as changing the value per mesh does not translate into a difference in slicing results.CURA-13325