move pii masking service to llmops#1701
Merged
Merged
Conversation
github-actions
Bot
added
test:uipath-langchain
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy SemanticProxy client surface and relocates the PII masking/detection functionality under the pii_detection package, updating the service endpoint to the LLMOps tenant route.
Changes:
- Renamed the client/service from
SemanticProxyServicetoPiiDetectionServiceand updated imports/tests accordingly. - Updated the PII detection endpoint path from
semanticproxy_tollmopstenant_. - Added an explicit per-request timeout override for PII detection calls.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/uipath-platform/tests/services/test_pii_utilities.py | Updates test imports to the new pii_detection public API surface. |
| packages/uipath-platform/tests/services/test_pii_detection_service.py | Renames tests and updates mocked URLs/imports for the new PII detection service + endpoint path. |
| packages/uipath-platform/src/uipath/platform/pii_detection/pii_utilities.py | Updates internal model imports to point at pii_detection models. |
| packages/uipath-platform/src/uipath/platform/pii_detection/pii_detection.py | Updates module docstring to reflect the new service naming. |
| packages/uipath-platform/src/uipath/platform/pii_detection/_pii_detection_service.py | Renames the service, changes the endpoint prefix to LLMOps tenant, and adds a longer request timeout. |
| packages/uipath-platform/src/uipath/platform/pii_detection/init.py | Re-exports the renamed service and reorganizes exports under the new package. |
| packages/uipath-platform/src/uipath/platform/_uipath.py | Replaces the semantic_proxy accessor with pii_detection on the main UiPath entry point. |
Comments suppressed due to low confidence (1)
packages/uipath-platform/src/uipath/platform/pii_detection/_pii_detection_service.py:18
_PII_DETECTION_TIMEOUT = 290.0is an unexplained magic number. Since this value is in seconds, it would be clearer and more maintainable to express it in terms of minutes/seconds while keeping the same effective timeout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yashwagle1
force-pushed
the
feat/movePIIMaskingToLLMops
branch
from
517b903 to
a5a7e66
Compare
🚨 Heads up:
|
yashwagle1
force-pushed
the
feat/movePIIMaskingToLLMops
branch
4 times, most recently
from
93e5b7f to
5f810e9
Compare
Contributor
|
nit: title is misleading ... |
yashwagle1
changed the title
saksharthakkar
approved these changes
Jun 5, 2026
Contributor
saksharthakkar
left a comment
saksharthakkar
left a comment
There was a problem hiding this comment.
approved with couple of nit comments
Adds PiiDetectionService (uipath.platform.pii_detection / sdk.pii_detection) pointing at llmopstenant_/api/pii-detection with a 290s request timeout. The existing SemanticProxyService (semanticproxy_/api/pii-detection) is kept unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drops the JSON-escaping helper (_add_escape_characters) from both pii_detection and semantic_proxy rehydration. Rehydration runs on plain LLM text, so JSON-escaping corrupted values containing quotes, newlines or backslashes; ordinary PII was unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yashwagle1
force-pushed
the
feat/movePIIMaskingToLLMops
branch
from
50471d3 to
ce5f012
Compare
🚨 Heads up:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.