chore(storybook): update IA + docs background#805
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
This PR reorganizes Storybook’s sidebar information architecture to better align with the monorepo’s package boundaries (Apollo Wind / Apollo React Canvas / Apollo React Material / Apollo Core) and fixes docs pages not reflecting the selected Apollo theme background.
Changes:
- Adds a custom DocsContainer wrapper that tracks the
themeglobal and applies the theme class to<body>for MDX-only docs pages. - Updates Storybook story sources and
storySortordering to group content under “Apollo Wind”, “Apollo React”, and “Apollo Core”. - Forces docs page surface background to use Apollo semantic tokens via
--color-background.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/storybook/.storybook/preview.tsx | Registers the custom docs container and updates sidebar sorting/grouping labels. |
| apps/storybook/.storybook/main.ts | Reorders story sources/title prefixes and injects docs background CSS based on Apollo tokens. |
| apps/storybook/.storybook/DocsContainer.tsx | New theme-aware docs container that syncs the toolbar theme to docs pages and body class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to organize storybook more correlated to the packages:
Apollo Wind
Apollo React / Canvas
Apollo React / Material
Apollo Core
Fix background color on docs pages.