Skip to content

GH-fix-GH-58 use newer python version in release process - #60

Merged
goulter merged 3 commits into
mainfrom
GH-fix-GH-58
Jun 16, 2026
Merged

GH-fix-GH-58 use newer python version in release process#60
goulter merged 3 commits into
mainfrom
GH-fix-GH-58

Conversation

@goulter

@goulter goulter commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Change Description: fix setuptools with newer python version. This is still related to getting uw-saml-python 1.2.9 released into pypi.

uw-saml-python Pull Request checklist

  • I have run ./scripts/pre-push.sh
  • I have selected a semver-guidance: label for this pull request (under labels,
    to the right of the screen)

If you do not do both of these things, your checks will either not run, or have a high probability of failing.

@goulter
goulter requested review from jdiverp and jprosser June 16, 2026 18:54
@goulter
goulter marked this pull request as ready for review June 16, 2026 18:54
Comment thread .github/workflows/create-release.yml Outdated
uses: actions/setup-python@v4
with:
python-version: "3.8"
python-version: "3.9"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should at the very least be 3.12 though 3.10 is not quite dead yet.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jprosser Oh, I understand for sure. I was just trying to move it up as little as possible to break as little as possible. I'll try 3.10 and see what happens :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but 3.10 is done in a few months basically. Also, perhaps aligning with identity.uw on 3.12 may be a smoother path forward.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.12 in latest commit

@goulter
goulter requested a review from jprosser June 16, 2026 20:39

@jprosser jprosser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot!

@goulter
goulter merged commit 8b5c681 into main Jun 16, 2026
1 check passed
@goulter
goulter deleted the GH-fix-GH-58 branch June 16, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants