Repository navigation
Remove sandbox configuration option from pcrglobwb/configuration.py - #99
Merged
vanjaarsveldbarry merged 1 commit intoNov 20, 2026
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the removal of sandbox-mode configuration support.
No open issues 🎉
What changed in this PR
This PR removes sandbox-mode support from PCR-GLOBWB configuration, eliminating its special handling of relative forcing, initial-condition, and output paths.
Changes:
- Removes the
relative_ini_meteo_pathsconstructor option and associated path-conversion helpers. - Removes sandbox-specific missing-file warnings and output-directory path normalization.
| File | Description |
|---|---|
src/pcrglobwb/configuration.py |
Removes the sandbox option, supporting state, path helpers, and logging. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the "sandbox" mode from pcrglobwb/configuration.py. That mode let a run use relative paths for the meteo forcing, the initial-condition files and the output directory.