Skip to content

Remove sandbox configuration option from pcrglobwb/configuration.py - #99

Merged
vanjaarsveldbarry merged 1 commit into
UU-Hydro:RAWSfrom
vanjaarsveldbarry:deprecate/sandbox_configuration
Nov 20, 2026
Merged

vanjaarsveldbarry merged 1 commit into
UU-Hydro:RAWSfrom
vanjaarsveldbarry:deprecate/sandbox_configuration

Conversation

@vanjaarsveldbarry

Copy link
Copy Markdown
Collaborator

This removes the "sandbox" mode from pcrglobwb/configuration.py. That mode let a run use relative paths for the meteo forcing, the initial-condition files and the output directory.

@vanjaarsveldbarry vanjaarsveldbarry added the RAWS Related to the RAWS project label Nov 20, 2026
@vanjaarsveldbarry
vanjaarsveldbarry requested a balanced review from Copilot November 20, 2026 10:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the removal of sandbox-mode configuration support.

No open issues 🎉

What changed in this PR

This PR removes sandbox-mode support from PCR-GLOBWB configuration, eliminating its special handling of relative forcing, initial-condition, and output paths.

Changes:

  • Removes the relative_ini_meteo_paths constructor option and associated path-conversion helpers.
  • Removes sandbox-specific missing-file warnings and output-directory path normalization.
File Description
src/​pcrglobwb/​configuration.py Removes the sandbox option, supporting state, path helpers, and logging.

Review effort: Balanced

@vanjaarsveldbarry
vanjaarsveldbarry merged commit 8380236 into UU-Hydro:RAWS Nov 20, 2026
2 checks passed
@vanjaarsveldbarry
vanjaarsveldbarry deleted the deprecate/sandbox_configuration branch November 20, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RAWS Related to the RAWS project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants