Prepare v2.1.3 release#143
Merged
Merged
Conversation
…copy marginals ArchimedeanCopula.ValidateParameter returned a non-null 'Parameter is valid' exception for in-range parameters; the Theta setter derives ParametersValid from a null return, so every family relying on the base implementation (Clayton, Gumbel, Joe) reported ParametersValid = false for valid parameters. The statistical functions tolerated it because their throwException guard path does not throw for valid values, which is why the defect never surfaced in computations. Valid parameters now return null, matching the Normal, StudentT, Frank, and AMH validators. Every copula Clone() also passed its marginal distributions by reference. Distributions memoize internal state lazily, so clones sharing marginals are not safe to use concurrently (one clone per thread in Monte Carlo frameworks, or parallel likelihood evaluation over IFM/full likelihoods). Clones now deep-copy attached marginals through a shared CloneMarginal helper; a marginal implementation outside UnivariateDistributionBase falls back to the shared reference, preserving the previous behavior for exotic implementations. Regression tests added for every family: ParametersValid tracks the theta range (fails before the fix for Clayton, Gumbel, and Joe) and Clone produces independent marginals with identical quantiles (fails before the fix for all seven families).
…s to MultivariateNormal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MultivariateNormal.Validation
dotnet restoredotnet build Numerics/Numerics.csproj -c Release /p:Version=2.1.3dotnet test -c ReleasewithVSTEST_CONNECTION_TIMEOUT=600dotnet pack Numerics/Numerics.csproj -c Release /p:Version=2.1.3 --no-build -o ./packages.nupkgmetadata and confirm version2.1.3and release notes are correct.