Enable logging for incoming server requests - #15
Open
purusharths wants to merge 2 commits into
Open
purusharths wants to merge 2 commits into
purusharths wants to merge 2 commits into
Conversation
Member
|
My preference would be to avoid writing extra files. Perhaps allowing for different levels of verbosity rather than bool would resolve this? @linusseelinger thoughts? |
Contributor
Author
|
Alright. I wanted to add the logging for python serve as well. Will employ the same approach as here once finalized. |
annereinarz
self-requested a review
July 1, 2026 10:13
annereinarz
reviewed
Jul 1, 2026
Member
There was a problem hiding this comment.
Why the change to port number, can we keep with our "default"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #14 (closed) without duplicate commits.
The server now prints out incoming requests with some associated metadata
Function call changed to:
UMBridge.serve_models([testmodel], 5232, true)with the lastBoolargument acting as a trigger to initiate logging (default argument isfalse).As of now, there's an extra level of verbosity with all
Evaluatecalls being printed out -> a possible resolution could be to export the logs to file instead.tail -f <filename> | grep "keywords"can then be used to filter for incoming requests. OR use a separate argument to enalbe logging for evaluate all together?The two TODO's mentioned in
with_logging, andserve_modelsrefer to which of the two approach would be preferred.