Skip to content

Three long-press features#211

Open
sastraxi wants to merge 11 commits into
feat/audio-midi-menufrom
feat/new-longpress-actions
Open

Three long-press features#211
sastraxi wants to merge 11 commits into
feat/audio-midi-menufrom
feat/new-longpress-actions

Conversation

@sastraxi

@sastraxi sastraxi commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Long-press emits a raw MIDI CC

longpress: {midi_CC: 64}

Fires RawMidiCcEffect(channel, cc) on long-press. First press sends 127, alternates thereafter. Uses fs.midi_channel + the dict's midi_CC; the footswitch's midi_CC (sibling to longpress) remains scoped to short-press. The footswitch LED stays in its PRESS role; the plugin tile reconciles via mod-ui's WS echo.

Long-press selects a snapshot

longpress: {preset: 2}
longpress: {preset: UP}
longpress: {preset: DOWN}

Reuses the existing PresetEffect on a LONGPRESS row. Specific index → preset_set_and_change; UP/DOWN → incr/decr.

Long-press scrolls pedalboards in-bank

longpress: {pedalboard: UP}
longpress: {pedalboard: DOWN}

New PedalboardEffect walks the current bank's ordered list with wraparound, falling back to the full alphabetical pedalboard_list when no bank is set.

Supporting changes

  • Config schema: longpress now accepts the object form (mutually-exclusive keys), and toggle_tuner_enable was added to the string enum (pre-existing drift)
  • Refactor: the O(N²) bank title→Pedalboard lookup is now a shared pedalboards_in_bank() on the handler; the LCD pedalboard menu uses it

sastraxi and others added 3 commits July 18, 2026 01:24
Cut verbose comments and drop PLAN.md / "Feature N" references.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace the bare dict with LongpressActionConfig (TypedDict), cast once at
the YAML parse boundary in set_longpress_groups.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@sastraxi
sastraxi requested a review from rreichenbach July 18, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant