fix(bridge): honor stop_at_eos=False in hf_generate - #1826
Merged
jlarson4 merged 1 commit intoSep 28, 2026
Merged
Conversation
Collaborator
|
Looks good, solid solution @emerardd, merging now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Honor
stop_at_eos=FalseinTransformerBridge.hf_generate()by explicitly passingeos_token_id=Noneto HuggingFace generation. Previously the wrapper omitted the argument, allowing HF to inheritmodel.generation_config.eos_token_idand stop early despite the Bridge flag.An offline zero-weight tiny GPT-2 with EOS 0 demonstrates the bug on
devat11224618: requesting three new tokens for[[1]]withstop_at_eos=Falsereturns[[1, 0]]; disabling EOS explicitly in HF returns[[1, 0, 0, 0]].Changes
stop_at_eos=False, without mutating the model's generation configuration.generate()semantics. This intentionally corrects the previous inconsistent precedence.This is independent of the seq2seq streaming fix in #1825 and is based directly on
dev.Type of change
Validation
mypy .passed for 385 source files.Checklist
Only the affected test surface was run, so the complete unit-suite checkbox is left unchecked. The existing interface tests were not rewritten.