Skip to content

ci: #58: fail calculate-tests-coverage-on-pull-request workflow when tests fail so that lower coverage from partially run tests is not published to readme badges #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaraevaAnastasia merged 5 commits into from
Oct 21, 2026
Merged

ci: #58: fail calculate-tests-coverage-on-pull-request workflow when tests fail so that lower coverage from partially run tests is not published to readme badges #70

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e0c07d
ci: #58: fail calculate-tests-coverage-on-pull-request workflow when …
SaraevaAnastasia Oct 20, 2026
d5ef20b
test: #58: temporarily break e2e test to check that calculate-tests-c…
SaraevaAnastasia Oct 20, 2026
8645f2b
test: #58: revert temporarily broken e2e test after checking that cal…
SaraevaAnastasia Oct 20, 2026
72d39f7
ci: #57: remove redundant comment
SaraevaAnastasia Oct 21, 2026
9ecc100
ci: #58: add set -e to calculate e2e tests coverage step for consiste…
SaraevaAnastasia Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/calculate-tests-coverage-on-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ jobs:
imageName: ghcr.io/${{ env.DEV_CONTAINER_IMAGE }}
cacheFrom: ghcr.io/${{ env.DEV_CONTAINER_IMAGE }}
runCmd: |
# stop on the first failed command, otherwise the step result depends only on the last command
# and coverage will be calculated even if the build or the tests failed
set -e

# first we build in Debug, then we re-use dlls using --no-build flag here and later
dotnet build

Expand All @@ -48,6 +52,8 @@ jobs:
with:
cacheFrom: ghcr.io/${{ env.DEV_CONTAINER_IMAGE }}
runCmd: |
set -e

# we need to run our Api and proceed to the next step
# that is why we forward its output and start it in background with & at the end
dotnet-coverage collect \
Expand All @@ -64,6 +70,8 @@ jobs:
with:
cacheFrom: ghcr.io/${{ env.DEV_CONTAINER_IMAGE }}
runCmd: |
set -e

java -jar /karate.jar .

dotnet-coverage shutdown calculate-e2e-coverage-session
Expand Down