Fix Repo URL, align file names, add test pipeline - #2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates repo/package metadata and refactors the ESLint plugin entrypoints/utilities while adding a GitHub Actions workflow intended for CI.
Changes:
- Bump package versions to
0.1.2and update repository/bugs/homepage URLs totimesplinter/ts-final. - Rename/realign ESLint plugin module entrypoints and extract shared utilities into
finalPluginUtils.ts. - Add a GitHub Actions workflow for CI and update the release workflow checkout action version.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/final-decorator/src/index.ts | Minor comment tweak in decorator implementation. |
| packages/final-decorator/package.json | Version bump + repository metadata updates. |
| packages/eslint-plugin-final/src/index.ts | Update plugin entry import to new filename. |
| packages/eslint-plugin-final/src/finalPluginUtils.ts | Add shared TypeScript/AST utility helpers for the plugin rules. |
| packages/eslint-plugin-final/src/finalPlugin.ts | Update imports to renamed utilities module. |
| packages/eslint-plugin-final/package.json | Version bump + repository metadata updates. |
| README.md | Reorganize usage documentation headings/sections. |
| .github/workflows/test.yml | Add CI workflow (currently build-only). |
| .github/workflows/release.yml | Update checkout action major version. |
Comments suppressed due to low confidence (1)
packages/eslint-plugin-final/src/finalPlugin.ts:7
- Same issue as in
src/index.ts: importing./finalPluginUtils.jsfrom TypeScript source while usingmoduleResolution: "Node"can break compilation because TS may not resolve.jsspecifiers to.tsfiles. Align the tsconfig module resolution (Node16/NodeNext/Bundler) or drop the.jsextension in the source import specifier.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1