Repository navigation
Installer: connect again without the port picker - #254
Merged
Merged
Conversation
The page remembers the USB ids of the port used last and opens it on its own after a lost connection (hub asleep, reset, unplugged), after a reload while connected, and on Connect. Disconnect and the firmware installer end that; 'Other port…' opens the picker. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Csa4N778M5kZxErLfAfd7D
ThomasPohl
changed the base branch from
refactor/installer-shared-code
to
main
November 15, 2026 06:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser's port picker came up for every connection: after a reload, after a reset of an ESP32-S3/C5 (its USB-Serial-JTAG returns as a new device) and every time a hub on battery woke up again.
The page now remembers the USB ids of the port used last and whether a connection is wanted, and opens the port itself (
serial-console.js):connectevent, and a check every second). Stop waiting ends that.reconnect()(used after a reset in the assistant and the dock) now waits for that one mechanism instead of opening the port itself, so two openers cannot collide;openPort()refuses a second open while one runs.Stacked on #253 (base switches to
mainafter that is merged).Tested in headless Chrome with a simulated port: loss and return (timer and
connectevent), reload while connected, Stop waiting, Connect without picker, Other port…, no auto-connect after Disconnect, reset from the dock, the assistant's step 3 after a reload. Not tested on hardware: a real USB-Serial-JTAG reset and a hub that falls asleep; whether Chrome reports the same USB ids after a re-enumeration is assumed (the previousreconnect()relied on it too).Generated by Claude Code