Fix scissor & cleanup GlStateManager calls#17
Merged
TexBlock merged 2 commits intoMay 28, 2025
Conversation
- This fixes certain elements not being properly scissored in 1.21.5+
- During the 1.21.5 port, I just replaced the previous instructions with GlStateManager ones, without realizing that Minecraft now already correctly handles them for us internally
Member
|
I've been a little busy lately, sorry I didn't see it until now, I'll merge it in a bit. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: replace scissor manager with builtin methods
clean: remove GlStateManager calls