ppl: avoid boundary PDN shapes when placing pins - #11102
Open
eder-matheus wants to merge 10 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the IOPlacer to prevent placing pins on slots blocked by boundary Power Delivery Network (PDN) shapes, modifying Hungarian matching to avoid blocked mirrored slots, and adding several integration tests. The review feedback highlights potential application crashes due to std::out_of_range exceptions when using .at() on layer maps, as well as potential null pointer dereferences and division-by-zero errors. It is recommended to implement safe helper functions to retrieve minimum widths and areas with proper fallbacks and bounds checking.
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
eder-matheus
force-pushed
the
ppl_pdn_boundary_1_slots
branch
from
August 11, 2026 12:46
b73e86e to
44257dd
Compare
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
… log Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Member
Author
|
@maliberty this PR partially solves a bug on our private PDKs. I'll have two other PRs to complete the fix, but this one is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
place_pinsandplace_pinignored boundary power grid geometry, so signal IOpins were placed on top of or abutting
-extend_to_boundarystraps and thepower/ground BPins
pdngencreates there, causing shorts and spacing violationsfound only at detailed route. Special net wires were never inspected on the die
edges, and fixed pins were only checked by a point test against the slot center
with no spacing margin.
Blocking shapes are now padded by the pin footprint plus the required spacing
(including the width dependent PARALLELRUNLENGTH rules for wide straps) and
shapes within pin reach of an edge are included, since pin shapes extend into
the die. Also fixed here: mirrored pins could still land on blocked slots,
excluded intervals were never applied to polygon die slots,
place_pin -force_to_die_boundarywas unaware of this geometry, and its offset search wasunbounded, which could push a pin outside the die area when an entire edge is
blocked (now reported as PPL-122).
First of three stacked PRs; the follow ups add routing obstructions, via landing
pads and top layer support, then the MINSPACING/EFFECTIVEWIDTH attributes.
Type of Change
Impact
Slots too close to boundary PDN geometry become unavailable, so IO pin positions
change in designs with boundary PDN. The ram tests show the expected effect:
available slots 270 -> 262 and I/O HPWL 310.66 -> 311.15 um (+0.16%), which
shifts two instances and the routing in their golden files. Designs without
boundary PDN geometry are unaffected. A pin that cannot fit on its edge now
fails with PPL-82 or PPL-122 instead of overlapping the power grid or leaving
the die.
Verification
./etc/Build.sh).162/162 ppl tests pass, including 10 new ones, plus the ram tests that consume
place_pins.Related Issues
N/A