gui: fix Unable to find visible display control at Timing Path/* - #11061
Open
LucasYuki wants to merge 1 commit into
Open
gui: fix Unable to find visible display control at Timing Path/*#11061LucasYuki wants to merge 1 commit into
LucasYuki wants to merge 1 commit into
Conversation
Signed-off-by: LucasYuki <lucasyuki@yahoo.com.br>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new method setRendererPaintingEnabled to toggle a renderer's active painting state without unregistering its display controls, ensuring they remain scriptable even when hidden. The review feedback suggests adding a null pointer check for the renderer parameter in setRendererPaintingEnabled to prevent potential crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #9391
Add a new method to register a renderer, so it's possible to find even if its parent is not active.
Type of Change
Impact
Now it's possible to use
gui::set_display_controls "Timing Path/*"if the Timing report is closed.Verification
./etc/Build.sh).Related Issues
#9391