iterate dbNets rather than sta nets when fetching parasitics - #4397
Open
AcKoucher wants to merge 2 commits into
Open
iterate dbNets rather than sta nets when fetching parasitics#4397AcKoucher wants to merge 2 commits into
AcKoucher wants to merge 2 commits into
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a helper function find_flat_db_net in flow/util/write_rc_helper.tcl to resolve flat database nets and refactors several functions to use it. It also adds deduplication logic to prevent processing the same flat net multiple times. The feedback highlights a potential runtime error in find_flat_db_net if sta::sta_to_db_mod_net returns "NULL", and suggests adding a check before calling findRelatedNet.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 61 design(s) checked — 8 with regression(s), 7 without a comparable baseline.
❌ asap7/ethmac base — 1 failing metric(s)
❌ asap7/ethmac_lvt base — 6 failing metric(s)
❌ asap7/mock-alu base — 1 failing metric(s)
❌ gf180/ibex base — 1 failing metric(s)
❌ gf180/riscv32i base — 3 failing metric(s)
❌ ihp-sg13g2/jpeg base — 1 failing metric(s)
❌ nangate45/mempool_group base — 3 failing metric(s)
❌ sky130hd/microwatt base — 5 failing metric(s)
|
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
AcKoucher
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #4405.
The script currently iterate sta nets and uses
sta_to_db_netwhich will returnnullptrfor module net. That caused the script to crash when trying to retrieve the type of that net.With the changes here we should be properly considering the parasitics of all
dbNets when fetching and preventing the crash.