Repository navigation
test: wait for the stored referrer before opening the join page - #194
Merged
Merged
Conversation
The join-page referral tests navigated away from /?ref=... before the home page's effect had stored the code, so the recruiter was sometimes missing (chromium on PRs, webkit on main). Wait for the stored code first, using the spec's existing storedReferrer poll.
Deploying palestine-pfp-maker with
|
| Latest commit: |
663e65b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4091f96a.palestine-pfp-maker.pages.dev |
| Branch Preview URL: | https://mostafazh-fix-main-ci.palestine-pfp-maker.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
credits the promoter whose link you arrived throughopened/?ref=zaher-7k2qand went straight to/leaderboard/join. The code is stored in an effect after hydration (src/app/page.tsx:77), so when the second navigation won, the join page had no recruiter. It failed on chromium on #189/#190 and on webkit on main.The test now waits with the spec's existing
storedReferrerpoll, and so does the channel-link test, which otherwise passed without checking anything. Ran 54/54 on chromium and 36/36 on webkit locally.