Repository navigation
feat: drag and zoom the photo so it can clear the name tag - #187
Merged
Merged
Conversation
Deploying palestine-pfp-maker with
|
| Latest commit: |
e45c43c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22a8baba.palestine-pfp-maker.pages.dev |
| Branch Preview URL: | https://mostafazh-photo-zoom.palestine-pfp-maker.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Members on the hub reported that the "T4P member" name tag lands on their chin or mouth. With a tightly cropped photo, or a tall photo that gets centre-cropped, the face fills the frame and the tag sits right on it.
On co-brand links (
?b=<code>), the photo can now be placed inside the frame:filter, so it rasterises the same in Blink, Gecko and WebKit.Other details:
Downloadednow carriesadjusted: on/off, so we can see whether people use it.The photo is now rendered by one
FramedPhotocomponent, shared by the page and the story card.Tests: tsc and lint clean, vitest 164/164. The branding, start-over, generate-pfp and link-first e2e specs pass on Chromium, Firefox and WebKit (42/42). A new test checks that zooming and dragging change the downloaded photo while every ring pixel stays the same, and that the slider is absent without a valid link.