Conversation
- /novels/filtered API에 platformNames(Array<String>) 파라미터 추가 - platformNames가 존재하면 해당 플랫폼에 등록된 소설만 조회 - NovelGenre 조인을 INNER → LEFT JOIN으로 변경하여 플랫폼 없는 소설도 포함)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67827ab488
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .status(OK) | ||
| .body(searchNovelApplication.getFilteredNovels(genres, keywordIds, isCompleted, novelRating, | ||
| novelRatingStart, novelRatingEnd, page, size)); | ||
| novelRatingStart, novelRatingEnd, platformNames, page, size)); |
There was a problem hiding this comment.
This added argument does not match SearchNovelApplication#getFilteredNovels, which still accepts only the previous eight parameters, so the project no longer compiles. The same application method also still calls NovelServiceImpl#findFilteredNovels without the newly required platformNames argument, so the filtered novels endpoint cannot be built until the application-layer signature and calls are updated together.
Useful? React with 👍 / 👎.
GiJungPark
left a comment
GiJungPark
left a comment
There was a problem hiding this comment.
엔티티 연관관계 맵핑 후, left join으로 같이 필터 걸리도록 수정한 부분 확인했습니다!
2 participants
Related Issue
Key Changes
/novels/filteredAPI에platformNames(Array<String>)쿼리 파라미터 추가platformNames가 존재하는 경우 해당 플랫폼에 등록된 소설만 조회platformNames가 없는 경우 기존과 동일하게 전체 조회Novel,Platform엔티티에novelPlatformsOneToMany 연관관계 추가NovelCustomRepositoryImpl에NovelPlatform,PlatformLEFT JOIN 및 플랫폼 필터 조건 추가To Reviewers
References