[REFACTOR] 피드 도메인 패키지 구조 및 조회 로직 개선#534
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
피드 도메인 패키지 구조 정리
feed하위로 이동했습니다.feed.feed: 피드 생성/수정/삭제/조회, 좋아요, 인기 피드feed.comment: 댓글 생성/수정/삭제/조회feed.report: 피드/댓글 신고피드 조회 로직 개선
List반환 방식에서Slice반환 방식으로 변경했습니다.isLoadable판단을 조회 결과 size 비교가 아닌Slice.hasNext()기준으로 변경했습니다.createdDate DESC, feedId DESCcreatedDate ASC, feedId ASC피드 Application / Service 책임 정리
FeedImageService로 분리했습니다.FeedServiceImpl#getOwnedFeedOrException으로 통일했습니다.이벤트 기반 처리 추가
버그 수정
PopularFeedService에 누락된@Transactional을 추가했습니다.To Reviewers
References