Skip to content

Fix/#523 #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GiJungPark merged 2 commits into from
Jun 9, 2026
Merged

Fix/#523 #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bf2173
[FIX] 인기 키워드 조회시 로그인 체크 제거(permit all)
ljy1348 Jun 8, 2026
5fc3925
[REFACTOR] 오늘의 발견 조회시 novelGenres필드 제거(미사용)
ljy1348 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/org/websoso/WSSServer/config/SecurityConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public class SecurityConfig {
"/auth/login/apple",
"/auth/apple/sync",
"/minimum-version",
"/keywords/popular",
};

private static final String[] swaggerPaths = {
Expand Down
11 changes: 4 additions & 7 deletions src/main/java/org/websoso/WSSServer/dto/popularNovel/PopularNovelGetResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,11 @@ public record PopularNovelGetResponse(
String author,
String genreName,
String novelDescription,
boolean isNovelCompleted,
List<String> novelGenres
boolean isNovelCompleted

) {

public static PopularNovelGetResponse of(Novel novel, AvatarProfile avatarProfile, Feed feed, List<String> keywords, List<String> genres) {
public static PopularNovelGetResponse of(Novel novel, AvatarProfile avatarProfile, Feed feed, List<String> keywords) {
if (avatarProfile == null && feed == null) {
return new PopularNovelGetResponse(
novel.getNovelId(),
Expand All @@ -34,8 +33,7 @@ public static PopularNovelGetResponse of(Novel novel, AvatarProfile avatarProfil
novel.getAuthor(),
novel.getFirstGenreName(),
novel.getNovelDescription(),
novel.getIsCompleted(),
genres
novel.getIsCompleted()

);
}
Expand All @@ -50,8 +48,7 @@ public static PopularNovelGetResponse of(Novel novel, AvatarProfile avatarProfil
novel.getAuthor(),
novel.getFirstGenreName(),
novel.getNovelDescription(),
novel.getIsCompleted(),
genres
novel.getIsCompleted()
);
}
}
9 changes: 3 additions & 6 deletions src/main/java/org/websoso/WSSServer/dto/popularNovel/PopularNovelsGetResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import java.util.List;
import java.util.Map;

import org.websoso.WSSServer.dto.keyword.KeywordGetResponse;
import org.websoso.WSSServer.library.domain.Keyword;
import org.websoso.WSSServer.user.domain.AvatarProfile;
import org.websoso.WSSServer.feed.domain.Feed;
Expand All @@ -23,14 +22,12 @@ public static PopularNovelsGetResponse create(List<Novel> popularNovels,
List<String> keywordGetResponsesList = keywords.get(novel.getNovelId()).stream()
.map(keyword -> keyword.getKeywordName())
.toList();
List<String> genres = novel.getNovelGenres().stream()
.map(novelGenre -> novelGenre.getGenre().getGenreName())
.toList();

if (feed == null) {
return PopularNovelGetResponse.of(novel, null, null, keywordGetResponsesList, genres);
return PopularNovelGetResponse.of(novel, null, null, keywordGetResponsesList);
}
AvatarProfile avatar = avatarMap.get(feed.getUser().getAvatarProfileId());
return PopularNovelGetResponse.of(novel, avatar, feed, keywordGetResponsesList, genres);
return PopularNovelGetResponse.of(novel, avatar, feed, keywordGetResponsesList);
})
.toList();
return new PopularNovelsGetResponse(popularNovelResponses);
Expand Down
Loading