Conversation
added 2 commits
May 31, 2026 19:58
GiJungPark
reviewed
Jun 2, 2026
Comment on lines
+23
to
+28
| List<String> keywordGetResponsesList = keywords.get(novel.getNovelId()).stream() | ||
| .map(keyword -> keyword.getKeywordName()) | ||
| .toList(); | ||
| List<String> genres = novel.getNovelGenres().stream() | ||
| .map(novelGenre -> novelGenre.getGenre().getGenreName()) | ||
| .toList(); |
Member
There was a problem hiding this comment.
p5; 뭔가 해당 메서드들은 공통으로 사용하는 부분이 많을 것 같은 느낌이 드네요.
나중에 일급 함수로 구분지어서 관리하면 편할 것 같기도 하네요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
get /novels/popular 조회시 필드 추가
author: 작가명
isNovelCompleted: 연재/완결 여부
novelGenres: 장르명
novelGenreImage: 작품 상세에서 사용 중인 장르 아이콘 이미지
keywords: 상위 연관 키워드 최대 2개
novelDescription: feedContent가 null일 때 대체로 보여줄 작품 소개
Feed 도메인에서 안쓰는 popularFedds 필드 제거
To Reviewers
References