feat(orchestrator): Telemetry - Trace running execution processing time - #334
Merged
morgan-wowk merged 1 commit intoAug 17, 2026
Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 17, 2026
Merged
morgan-wowk
marked this pull request as ready for review
August 17, 2026 22:56
Ark-kun
approved these changes
Aug 17, 2026
Ark-kun
changed the title
Collaborator
Author
Merge activity
|
morgan-wowk
added a commit
that referenced
this pull request
Aug 17, 2026
…info retrieval time (#335) Wraps the output-artifact `get_info()` resolution in the `SUCCEEDED` branch of `internal_process_one_running_execution` in a child span (`orchestrator.get_output_artifact_info`). ## Why This `get_reader().get_info()` call walks and stats **every file** of each output artifact on the single orchestrator thread. For a large Directory artifact (the inv-26772 trigger: ~88k per-merchant files) this is the confirmed freeze hot path — it runs for 40+ minutes and blocks all other executions. The span isolates that hot path within the parent processing span so its duration is directly measurable. Timing-only, by design: per review, artifact **byte size** does not predict the stall (multi-gig artifacts resolve fast); **file count** is the meaningful dimension but is not available cheaply at this point, so no attribute is attached rather than a misleading one. ## Impact One child span per succeeded execution's output resolution, nested under `orchestrator.process_running_execution` from [#334](#334). No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps the per-running-execution processing call in
internal_process_running_executions_queuein atangle.orchestratorspan (orchestrator.process_running_execution), attributed bycontainer_execution.id.Why
Investigation of inv-26772 (orchestrator intermittently stalling) showed that attributing a freeze to the execution that caused it currently requires hand-correlating the
After processing running container execution (duration: …ms)log with the launcher logs to recover the namespace. This span makes that per-execution processing duration a first-class, queryable signal keyed by the execution id, so "which execution blocked the loop, and for how long" is a single query instead of manual log archaeology.Complements the query-timing logs added in #331 by turning the per-execution processing duration into an attributed span.
Naming
Uses
container_execution.id(notexecution.id): the processing loop operates on aContainerExecution, matching thecontextual_loggingkey and thecloud-pipelines.net/orchestration/container_execution.idannotation.execution_tracing.pyalready usesexecution.idfor anExecutionNode(a different entity), so this avoids overloading one key for two entities.Impact
One span per running-execution processing pass; it becomes the parent for any child spans emitted during processing. No behavior change.