Skip to content

fix(ui): click events not working on dropdowns in search dialog#791

Open
IdrisGit wants to merge 1 commit intoTanStack:mainfrom
IdrisGit:fix-search-dialog-dropdown-selection
Open

fix(ui): click events not working on dropdowns in search dialog#791
IdrisGit wants to merge 1 commit intoTanStack:mainfrom
IdrisGit:fix-search-dialog-dropdown-selection

Conversation

@IdrisGit
Copy link
Copy Markdown

@IdrisGit IdrisGit commented Mar 27, 2026

Upgrade Radix Dialog and Dropdown primitives to their latest versions and pin those versions to prevent version mismatch during dependency resolution.

This addresses known issues with dismissable layer and pointer-events in Radix components due to mismatch in resolved dependencies after installation.

These are the links active issues in Radix:

A similar issue (related to pointer-events) was fixed in Ghost (TryGhost/Ghost#26102) using this approach (and it's the most consistent method discussed in Radix issues as well).

dropdown-fix-demo-compressed.mp4

Summary by CodeRabbit

  • Chores
    • Updated Radix UI component dependencies for enhanced stability and consistency. These changes include updates to dialog and dropdown menu components, ensuring more predictable and reliable behavior across various development and deployment environments. Dependencies are now pinned to specific versions for improved reproducibility and consistent builds.

upgraded Radix Dialog, and Dropdown primitives to the latest version and pinned those versions to address the known overlay and pointer-events bugs in Radix due to mismatch in the resolved versions after installation
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 27, 2026

👷 Deploy request for tanstack pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8888769

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 59f9231e-066d-4d14-aadd-9855c2e6dcb6

📥 Commits

Reviewing files that changed from the base of the PR and between e71479b and 8888769.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

Package.json dependency specifications for Radix UI packages were updated: @radix-ui/react-dialog pinned to exact version 1.1.15, and @radix-ui/react-dropdown-menu updated to exact version 2.1.16 (previously caret-ranged specifications).

Changes

Cohort / File(s) Summary
Dependency Version Updates
package.json
Pinned @radix-ui/react-dialog to exact version 1.1.15 and updated @radix-ui/react-dropdown-menu to exact version 2.1.16, removing caret-range constraints.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop and a skip through dependencies so fine,
Radix UI versions now lock in line,
No more carets floating free,
Exact pins set the spree,
Clean constraints make things align!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing click events on dropdowns in search dialogs by upgrading Radix UI dependencies to resolve known pointer-events issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant