fix(ui): click events not working on dropdowns in search dialog#791
fix(ui): click events not working on dropdowns in search dialog#791IdrisGit wants to merge 1 commit intoTanStack:mainfrom
Conversation
upgraded Radix Dialog, and Dropdown primitives to the latest version and pinned those versions to address the known overlay and pointer-events bugs in Radix due to mismatch in the resolved versions after installation
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPackage.json dependency specifications for Radix UI packages were updated: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Upgrade Radix Dialog and Dropdown primitives to their latest versions and pin those versions to prevent version mismatch during dependency resolution.
This addresses known issues with dismissable layer and pointer-events in Radix components due to mismatch in resolved dependencies after installation.
These are the links active issues in Radix:
A similar issue (related to pointer-events) was fixed in Ghost (TryGhost/Ghost#26102) using this approach (and it's the most consistent method discussed in Radix issues as well).
dropdown-fix-demo-compressed.mp4
Summary by CodeRabbit