fix: match navbar Suspense fallback to loaded wrapper#790
fix: match navbar Suspense fallback to loaded wrapper#790franklinjavier wants to merge 1 commit intoTanStack:mainfrom
Conversation
The fallback rendered LogoSection without a wrapper div, but the loaded state wrapped it in a div with flex/shrink classes. This mismatch caused a layout shift when BrandContextMenu loaded.
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA React Suspense fallback in the Navbar component was refactored to wrap the LogoSection component in a styled Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
LogoSectionin a<div>with the sameflex items-center group flex-shrink-0classes thatLazyBrandContextMenuusesTest plan
Summary by CodeRabbit