Skip to content

Support manual TablePlus import path - #625

Open
DhruvShah-Dev wants to merge 2 commits into
TabularisDB:mainfrom
DhruvShah-Dev:fix/tableplus-manual-import-path
Open

Support manual TablePlus import path#625
DhruvShah-Dev wants to merge 2 commits into
TabularisDB:mainfrom
DhruvShah-Dev:fix/tableplus-manual-import-path

Conversation

@DhruvShah-Dev

Copy link
Copy Markdown
Contributor

Summary

  • Allows TablePlus imports to use a user-selected config path when auto-discovery fails.
  • Accepts a selected TablePlus Data directory or a plist file inside that directory on the backend.
  • Keeps normal auto-discovery behavior unchanged when TablePlus data is found automatically.
  • Adds importer coverage for a moved TablePlus data directory.

Root Cause

The TablePlus importer only looked in known Application Support locations. If TablePlus was configured to store its files elsewhere, the import source appeared unavailable and there was no way to provide the moved path.

Fixes #620

Validation

  • git diff --check
  • pnpm.cmd exec tsc --noEmit
  • pnpm.cmd exec eslint src/components/modals/ImportFromAppModal.tsx src/types/connectionImport.ts
  • cargo test tableplus_import_accepts_manual_data_dir --lib -- --nocapture timed out locally after 4 minutes during Rust execution/build.

@DhruvShah-Dev
DhruvShah-Dev marked this pull request as ready for review August 11, 2026 20:27
Comment thread src/i18n/locales/it.json Outdated
"previewSubtitle": "Rivedi le connessioni da {{source}}",
"notInstalled": "Non installato",
"chooseFile": "Scegli un file di esportazione da importare",
"chooseConfigPath": "Choose the app config folder to import",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: chooseConfigPath is left in English for locales that otherwise translate their strings

The surrounding keys (notInstalled, chooseFile) are translated in it.json, ko.json, pt-BR.json, and tl.json, but the new chooseConfigPath value is English in all four. Provide localized translations for these locales to avoid a mixed-language UI.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The previously reported CRITICAL (Continue button disabled guard not allowing manual-path sources) and SUGGESTION (chooseConfigPath left in English for it/ko/pt-BR/tl) have both been resolved in commit 2e6aed8.

  • The new canContinueFromPicker helper (lines 137–141) is the De Morgan equivalent of the handleContinue early-return guard, so the footer button and the handler now agree on which sources may proceed (including non-available needsFile/manualPathSupported sources).
  • chooseConfigPath is now translated in it.json, ko.json, pt-BR.json, and tl.json.

No new issues were found in the changed lines.

Files Reviewed (5 files)
  • src/components/modals/ImportFromAppModal.tsx
  • src/i18n/locales/it.json
  • src/i18n/locales/ko.json
  • src/i18n/locales/pt-BR.json
  • src/i18n/locales/tl.json
Previous Review Summary (commit e2fa7dc)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit e2fa7dc)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 1
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

CRITICAL

File Line Issue
src/components/modals/ImportFromAppModal.tsx 544 The "Continue" footer button still uses `disabled={!selectedSource?.available

SUGGESTION

File Line Issue
src/i18n/locales/it.json 358 New chooseConfigPath is English in locales that otherwise translate (it, ko, pt-BR, tl).
Files Reviewed (17 files)
  • src-tauri/src/connection_import/importer_tests.rs — 0 issues
  • src-tauri/src/connection_import/mod.rs — 0 issues
  • src-tauri/src/connection_import/tableplus.rs — 0 issues
  • src-tauri/src/connection_import_commands.rs — 0 issues
  • src/components/modals/ImportFromAppModal.tsx — 1 issue
  • src/types/connectionImport.ts — 0 issues
  • src/i18n/locales/*.json (de, en, es, fr, it, ja, ko, pt-BR, ru, tl, zh) — 1 issue

Fix these issues in Kilo Cloud


Reviewed by glm-5.2 · Input: 49.4K · Output: 5.6K · Cached: 214.5K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: import connection from tableplus

1 participant