Support manual TablePlus import path - #625
Conversation
| "previewSubtitle": "Rivedi le connessioni da {{source}}", | ||
| "notInstalled": "Non installato", | ||
| "chooseFile": "Scegli un file di esportazione da importare", | ||
| "chooseConfigPath": "Choose the app config folder to import", |
There was a problem hiding this comment.
SUGGESTION: chooseConfigPath is left in English for locales that otherwise translate their strings
The surrounding keys (notInstalled, chooseFile) are translated in it.json, ko.json, pt-BR.json, and tl.json, but the new chooseConfigPath value is English in all four. Provide localized translations for these locales to avoid a mixed-language UI.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The previously reported CRITICAL (Continue button
No new issues were found in the changed lines. Files Reviewed (5 files)
Previous Review Summary (commit e2fa7dc)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit e2fa7dc)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
SUGGESTION
Files Reviewed (17 files)
Reviewed by glm-5.2 · Input: 49.4K · Output: 5.6K · Cached: 214.5K |
Summary
Datadirectory or a plist file inside that directory on the backend.Root Cause
The TablePlus importer only looked in known Application Support locations. If TablePlus was configured to store its files elsewhere, the import source appeared unavailable and there was no way to provide the moved path.
Fixes #620
Validation
git diff --checkpnpm.cmd exec tsc --noEmitpnpm.cmd exec eslint src/components/modals/ImportFromAppModal.tsx src/types/connectionImport.tscargo test tableplus_import_accepts_manual_data_dir --lib -- --nocapturetimed out locally after 4 minutes during Rust execution/build.