9주차 미션 제출합니다.#29
Open
jaeimin wants to merge 2 commits into
Open
Conversation
wonjun0120
reviewed
Nov 26, 2025
wonjun0120
left a comment
wonjun0120
left a comment
Contributor
There was a problem hiding this comment.
구현이 필요한 API 목록중 2개만 보이는것 같은데 확인 바랍니다
확인한 API
- 특정 가게의 미션 목록
- 내가 진행중인 미션 목록
확인할 수 없는 API
- 내가 작성한 리뷰 목록 (삭제됨)
- 진행중인 미션 진행 완료로 바꾸기
4개중 3개 이상을 구현해야합니다
제가 확인하지 못한거라면, 답변주시고, 카톡도 같이 주세요
Contributor
There was a problem hiding this comment.
인터페이스와 구현체로 분리한 이유가 무엇일까요?
지금처럼 구현체가 딱 하나인 경우에는 인터페이스가 있어야할까요?
| @Override | ||
| public ReviewResponseDto.ReviewPreViewListDTO getMyReviews(Long userId, int page) { | ||
|
|
||
| PageRequest pageRequest = PageRequest.of(page - 1, 10); |
Contributor
There was a problem hiding this comment.
컨트롤러에서 넘어오는 페이지가 1부터 시작한다는 가정하에 작성된 것으로 보이는데,
이는 API를 어떻게 결정하는지에 따라 달라집니다.
이 경우는 controller 계층에서 정리해주는게 적절해보입니다
Contributor
There was a problem hiding this comment.
10의 경우도 변수로 따로 분리하여 관리하는게 더 좋지 않을까요
Contributor
There was a problem hiding this comment.
미션에 있는 "내가 작성한 리뷰 목록" 기능은 없는건가요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
김재민 / 재이미 9주차 과제 제출합니다.