[5주차] 워크북 미션 - jaehyuk#8
Open
gotukorea wants to merge 1 commit into
Open
Conversation
Contributor
|
재혁 님, 5주차 미션 수행하시느라 고생 많으셨습니다! 기술적인 부분에서는 어노테이션 활용이 다소 미흡한 점이 눈에 띕니다. 예를 들어 MemberReqDTO와 같은 DTO 클래스에서 @Getter가 누락되거나 생성자 초기화가 제대로 되지 않으면, Spring이 요청 데이터를 바인딩하지 못해 필드값이 null이 될 수 있습니다. 이를 방지하기 위해 Java의 record 형태를 도입하거나 Lombok 어노테이션을 꼼꼼히 체크해 보시길 권장합니다. 또한, 현재 Member, Mission, Review와 관련된 모든 컨트롤러가 /members 엔드포인트로 설정되어 있는데, 각 도메인의 성격에 맞게 경로를 분리하여 RESTful한 설계를 반영해 주시면 좋겠습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApiResponse 객체를 응답통일 위해 사용했습니다,
예외 처리는 @RestControllerAdvice를 활용한 GlobalExceptionHandler를 통해 공통적으로 처리하도록 구성하였습니다.