7주차 미션_담담#22
Open
sungs25 wants to merge 10 commits into
Open
Conversation
added 9 commits
May 15, 2026 18:13
kimdoyeon1234
left a comment
Collaborator
There was a problem hiding this comment.
수고하셨습니다!
Type-safe Navigation 올바르게 적용하셨고, 파일 분리도 완벽하게 되어있어요!
콜백 네이밍(onOrderClick, onEditClick, onTabClick)도 동사+목적어로 일관성 있게 잘 지키고 있어서 좋았습니다!
지금도 좋지만 수정하면 좋을점 남겨두었습니다!
-
ShopScreen 내부의 selectedTab 상태가 고립되어 있어요!State Hoisting을 적용해서 상위로 끌어올리면 좋을거 같아요!
-
State Hoisting
fun ShopScreen(
selectedTab: Int,
onTabSelected: (Int) -> Unit,
modifier: Modifier = Modifier
)
전반적으로 이번 주차 코드 중 가장 완성도가 높아요! 다음 주차도 화이팅 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
📸 스크린샷
🙏 리뷰 요구사항 (선택)