[FIX/#309] 2차 QA 매칭, 알림 뷰 문구 수정#310
Merged
Merged
Conversation
- NoticeScreen 내 하드코딩된 문자열을 strings.xml 리소스로 대체 - 종목명(SportType)에 따른 적절한 조사(으로/로) 선택 로직 추가 - 다이얼로그 제목, 부제목, 버튼 텍스트 리소스 추가 및 적용
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
워크스루사용자 정보 관련 저장소 메서드를 제거하고, SportType의 매핑 함수를 삭제하며, ConfirmReviewScreen에서 네비게이션 콜백을 제거하고, NoticeScreen의 하드코딩된 한글 문자열을 매개변수화된 string 리소스로 교체한 QA 수정 사항입니다. 변경 사항
코드 리뷰 예상 소요 시간🎯 3 (보통) | ⏱️ ~20분 관련 가능성 있는 PR
추천 라벨
추천 리뷰어
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/src/main/java/com/smashing/app/presentation/notice/NoticeScreen.kt (1)
145-147: 조사(으로/로) 선택 로직을 종목 하드코딩에서 일반 규칙으로 분리해 주세요.Line 146은 현재
BADMINTON만 예외 처리하고 있어, 종목이 추가되면 문구가 쉽게 깨질 수 있습니다. 문자열 말미 받침 기준 유틸로 분리하는 쪽이 안전합니다.리팩터 예시
- val sport = uiState.targetChangeSport.sportType - val sportText = sport.sportName + if (sport == SportType.BADMINTON) "으로" else "로" + val sport = uiState.targetChangeSport.sportType + val sportText = sport.sportName + sport.sportName.selectEuroRoParticle()private fun String.selectEuroRoParticle(): String { val last = this.lastOrNull() ?: return "로" if (last !in '가'..'힣') return "로" val jong = (last.code - '가'.code) % 28 // 종성이 없거나 종성이 ㄹ(8)이면 "로", 그 외는 "으로" return if (jong == 0 || jong == 8) "로" else "으로" }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/src/main/java/com/smashing/app/presentation/notice/NoticeScreen.kt` around lines 145 - 147, Current logic in NoticeScreen.kt uses a hardcoded BADMINTON check to pick "으로"/"로" for sport text; extract this into a general Hangul-final-consonant utility and use it instead of the equality check. Add a String extension (e.g., selectEuroRoParticle()) that inspects the last Hangul syllable's jongseong (as in the provided example) and returns "으로" or "로", then replace the line that builds sportText (currently referencing uiState.targetChangeSport.sportType and sport.sportName) to append sport.sportName.selectEuroRoParticle() so new sports won't break the particle selection.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/res/values/strings.xml`:
- Line 1: Root-level tools:ignore="MissingTranslation" on the <resources>
element hides all missing-translation warnings; change it to target only the
specific string(s) that intentionally lack translations (move
tools:ignore="MissingTranslation" from the root to the individual <string>
entries that need suppression) and add a TODO comment or tracking identifier in
those string entries indicating this is temporary and when/why it should be
removed; update any affected identifiers (string names) accordingly so the
suppression is localized and auditable.
---
Nitpick comments:
In `@app/src/main/java/com/smashing/app/presentation/notice/NoticeScreen.kt`:
- Around line 145-147: Current logic in NoticeScreen.kt uses a hardcoded
BADMINTON check to pick "으로"/"로" for sport text; extract this into a general
Hangul-final-consonant utility and use it instead of the equality check. Add a
String extension (e.g., selectEuroRoParticle()) that inspects the last Hangul
syllable's jongseong (as in the provided example) and returns "으로" or "로", then
replace the line that builds sportText (currently referencing
uiState.targetChangeSport.sportType and sport.sportName) to append
sport.sportName.selectEuroRoParticle() so new sports won't break the particle
selection.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 08ecfc32-68c5-4cd1-b959-ab2dfec8934c
📒 Files selected for processing (6)
app/src/main/java/com/smashing/app/data/repository/api/UserRepository.ktapp/src/main/java/com/smashing/app/data/repository/impl/UserRepositoryImpl.ktapp/src/main/java/com/smashing/app/data/type/SportType.ktapp/src/main/java/com/smashing/app/presentation/confirmreview/ConfirmReviewScreen.ktapp/src/main/java/com/smashing/app/presentation/notice/NoticeScreen.ktapp/src/main/res/values/strings.xml
💤 Files with no reviewable changes (1)
- app/src/main/java/com/smashing/app/data/repository/impl/UserRepositoryImpl.kt
| @@ -1,4 +1,5 @@ | |||
| <resources> | |||
| <resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="MissingTranslation"> | |||
There was a problem hiding this comment.
전역 MissingTranslation 무시는 범위를 축소하는 것이 안전합니다.
Line 1에서 루트 resources에 tools:ignore="MissingTranslation"를 걸면 신규 문자열 번역 누락이 계속 숨겨집니다. 필요한 항목에만 국소적으로 suppress 하거나, 임시 대응이라면 추후 제거 계획을 명시해 주세요.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@app/src/main/res/values/strings.xml` at line 1, Root-level
tools:ignore="MissingTranslation" on the <resources> element hides all
missing-translation warnings; change it to target only the specific string(s)
that intentionally lack translations (move tools:ignore="MissingTranslation"
from the root to the individual <string> entries that need suppression) and add
a TODO comment or tracking identifier in those string entries indicating this is
temporary and when/why it should be removed; update any affected identifiers
(string names) accordingly so the suppression is localized and auditable.
ShinHyeongcheol
approved these changes
Apr 8, 2026
ShinHyeongcheol
left a comment
ShinHyeongcheol
left a comment
Collaborator
There was a problem hiding this comment.
좋아요!! 수고하셨습니다아ㅏㅏ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
N/A
Uncompleted Tasks 😅
To Reviewers 📢
QA 사항 중 문구가 일부 다른 부분을 수정했습니다.
SSE 쪽은 아직 처리될 부분이 남아서 서버 쪽에서 수정해주시면 새로 이슈 파서 작업할게요.
Summary by CodeRabbit
릴리스 노트
새로운 기능
개선 사항
리팩토링