Add localized default labels for TwoOptions - #65
Merged
Merged
Conversation
Contributor
|
Thanks for the change, I would only prefer to use the labels object directly behind the || instead of merging it to the options array, otherwise lgtm. |
Review feedback: keep the metadata options array untouched and put the localized labels behind the || in the Toggle props.
tompivny
force-pushed
the
fix/two-options-default-labels
branch
from
August 26, 2026 06:32
e4c7beb to
87f5801
Compare
brYch97
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When column metadata carries no boolean option labels,
TwoOptionsfell back to hardcoded English'Yes'/'No', ignoring the user's language.Change
translations.tswired throughuseControlany, so consumers can override.