Conversation
…me polishing but is functional.
…ged and I changed eff_width to be the half width to line up with its use in other functions. These tests pass but others fail - to be checked
sahinya17
reviewed
Apr 23, 2026
sahinya17
left a comment
sahinya17
left a comment
Collaborator
There was a problem hiding this comment.
Just 2 minor things I caught
|
|
||
|
|
||
| if( is.null(avg_min_distance ) & is.null(df_turbines)){ | ||
| stop("Please enter one of eff_detection_width or avg_min_distance") |
Collaborator
There was a problem hiding this comment.
I think this test is throwing the wrong error message
| } | ||
|
|
||
| if( !is.null(avg_min_distance) & !is.null(df_turbines)){ | ||
| stop("Please enter only one of eff_detection_width and avg_min_distance") |
Collaborator
There was a problem hiding this comment.
I think this test is throwing the wrong error message
sahinya17
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cluster correction