Skip to content

Fix: chore(launch): rotate and vault all mainnet secrets (RPC keys, admin keys, DB creds) in a proper secrets manager - #1452

Merged
0xDeon merged 3 commits into
Suncrest-Labs:devfrom
helloworld1-star:fix/issue-1383-1790674021275
Oct 2, 2026
Merged

0xDeon merged 3 commits into
Suncrest-Labs:devfrom
helloworld1-star:fix/issue-1383-1790674021275

Conversation

@helloworld1-star

Copy link
Copy Markdown
Contributor

Closes #1383

Changes

Rotate and vault all mainnet secrets in a secure secrets manager abstraction/utility and remove hardcoded secrets.

Verification

✅ The repository's own CI was run on this branch (on the contributor's fork) before opening this PR: every check passed except Dependency Audit (Go) (apps/api), Dependency Audit (pnpm) — they fail on dev without this change too (the same CI run on the untouched base commit 12d1b43), so they aren't caused by this PR. The change is within the issue's scope.

…ecrets (RPC keys, admin keys, DB creds) in a proper secrets manager
@drips-wave

drips-wave Bot commented Sep 29, 2026

Copy link
Copy Markdown

@helloworld1-star Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@netlify

netlify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for nesterhq canceled.

Name Link
🔨 Latest commit c9073b3
🔍 Latest deploy log https://app.netlify.com/projects/nesterhq/deploys/6abf09198a1a1a00076b8877

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: Suncrest-Labs/nester/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a054eafe-15c6-4795-8ccc-666589518470

📥 Commits

Reviewing files that changed from the base of the PR and between 62da5b3 and c9073b3.

📒 Files selected for processing (1)
  • src/secrets/vault.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for nesterdapp ready!

Name Link
🔨 Latest commit c9073b3
🔍 Latest deploy log https://app.netlify.com/projects/nesterdapp/deploys/6abf091900b35000084ecd57
😎 Deploy Preview https://deploy-preview-1452--nesterdapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@0xDeon
0xDeon merged commit d470432 into Suncrest-Labs:dev Oct 2, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(launch): rotate and vault all mainnet secrets (RPC keys, admin keys, DB creds) in a proper secrets manager

2 participants