feat: implement Stellar wallet address validation - #207
Merged
SudiptaPaul-31 merged 1 commit intoOct 3, 2026
Merged
SudiptaPaul-31 merged 1 commit into
SudiptaPaul-31 merged 1 commit into
Conversation
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@AugistineCreates is attempting to deploy a commit to the Sudipta 's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #196
Adds robust validation for Stellar wallet addresses before they are stored or used in blockchain operations. This prevents malformed or incompatible addresses from reaching transaction and ownership workflows.
Tasks Completed
✅ Implemented validateStellarAddress utility leveraging stellar-sdk's StrKey.isValidEd25519PublicKey for robust validation and checksum checking.
✅ Integrated the validation utility into authentication (lib/stellar-auth.ts), transaction (lib/stellar.ts), and ownership workflows.
✅ Handled valid, invalid, and edge cases gracefully by returning clear error feedback to avoid silent failures.
✅ Added a comprehensive suite of unit tests covering the validation utility.
Acceptance Criteria Met
Only valid Stellar addresses are accepted; malformed addresses are immediately rejected with standardized errors.
Checks are highly reusable and enforce consistent wallet address requirements across all services.
Database integrity is completely preserved by intercepting invalid inputs before storage or on-chain submission.