Skip to content

feat: evaluate for #[jsonschema::validator]-generated validators#1210

Draft
Stranger6667 wants to merge 1 commit into
masterfrom
feat/codegen-evaluate
Draft

feat: evaluate for #[jsonschema::validator]-generated validators#1210
Stranger6667 wants to merge 1 commit into
masterfrom
feat/codegen-evaluate

Conversation

@Stranger6667

Copy link
Copy Markdown
Owner

No description provided.

@Stranger6667
Stranger6667 force-pushed the feat/codegen-evaluate branch from a7cec04 to 25e8a6a Compare July 12, 2026 21:31
@codspeed-hq

codspeed-hq Bot commented Jul 12, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 54.17%

⚡ 1 improved benchmark
❌ 7 regressed benchmarks
✅ 106 untouched benchmarks
🆕 8 new benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation generate[Swagger] 24.9 ms 67.4 ms -63.02%
Simulation generate[Open API] 26.9 ms 70.1 ms -61.61%
Simulation generate[GeoJSON] 9.3 ms 23.9 ms -60.86%
Simulation generate[CITM] 4.6 ms 11.4 ms -59.87%
Simulation generate[Fast] 1.4 ms 3.5 ms -59.41%
Simulation generate[Recursive] 10.5 ms 24.4 ms -57.15%
Simulation generate[FHIR] 1.1 s 2.4 s -55.09%
Simulation codegen/Fast/is_valid[Invalid] 275.6 ns 246.4 ns +11.84%
🆕 Simulation codegen/CITM/evaluate[Catalog] N/A 47.5 ms N/A
🆕 Simulation codegen/Fast/evaluate[Invalid] N/A 32 µs N/A
🆕 Simulation codegen/Fast/evaluate[Valid] N/A 28.5 µs N/A
🆕 Simulation codegen/FHIR/evaluate[Fhir] N/A 128.4 µs N/A
🆕 Simulation codegen/GeoJSON/evaluate[Canada] N/A 68.9 ms N/A
🆕 Simulation codegen/Open API/evaluate[Zuora] N/A 150 ms N/A
🆕 Simulation codegen/Recursive/evaluate[StructuredContent] N/A 622.1 µs N/A
🆕 Simulation codegen/Swagger/evaluate[Kubernetes] N/A 135.5 ms N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing feat/codegen-evaluate (2b4b9ee) with master (e73781f)

Open in CodSpeed

@Stranger6667
Stranger6667 force-pushed the feat/codegen-evaluate branch 3 times, most recently from d06494e to b726353 Compare July 13, 2026 00:17
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.61443% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.22%. Comparing base (6eb2690) to head (d123a06).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema/src/validator.rs 56.09% 18 Missing ⚠️
...s/jsonschema-macros-core/src/codegen/evaluation.rs 99.41% 8 Missing ⚠️
...schema-macros-core/src/codegen/unevaluated_scan.rs 96.84% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
+ Coverage   95.96%   96.22%   +0.25%     
==========================================
  Files         142      144       +2     
  Lines       32243    34212    +1969     
==========================================
+ Hits        30942    32919    +1977     
+ Misses       1301     1293       -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Stranger6667
Stranger6667 force-pushed the feat/codegen-evaluate branch 14 times, most recently from d123a06 to 10f1a28 Compare July 16, 2026 17:56
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
@Stranger6667
Stranger6667 force-pushed the feat/codegen-evaluate branch from 2b4b9ee to 750ebb0 Compare July 16, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant