Repository navigation
Conversation
…-split#781) - Export pure computeMovingAverage(samples, windowSize) in fees/trend.ts - Returns SMA series with first windowSize-1 entries padded as NaN - Throws RangeError for windowSize < 1 - Leaves input array untouched - Add unit tests for padding, exact averages, edge cases, and immutability Closes Stellar-split#781
Contributor
|
Closing this PR — it was opened against an issue that wasn't assigned to you. To avoid duplicate work, please wait for an issue to be assigned before submitting a PR for it. Feel free to comment on the issue to request assignment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pure, stateless
computeMovingAveragehelper tofees/trend.tsso callers can smooth raw fee samples before percentile-based recommendation.Changes
computeMovingAverage(samples: number[], windowSize: number): number[]windowSize - 1entries areNaN(insufficient data).RangeErrorwhenwindowSize < 1.test/feeTrend.test.tscovers padding, hand-calculated averages, windowSize = 1, oversize window, empty input, negative window, and immutability.Closes #781