Repository navigation
fix(split): reject invalid runtime ratio legs - #1024
Open
woahwhattheheck wants to merge 2 commits into
Open
woahwhattheheck wants to merge 2 commits into
woahwhattheheck wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1012
Summary
[0, 1]undefined) from explicitnulland other wrong-type valuesSplitRatioSumErrorcode/fieldsScope
Two files only, based on exact upstream
main@230fe3f67e806fbd0f0e67a29bd7b90ffec80789:src/payments/splitExecutor.tstest/splitExecutor.invalid-ratios.test.tsThe earlier competing PR #1015 is closed unmerged. This carrier implements the repair already documented and claimed in #1012, including the additional runtime
null/wrong-type escape found during source review.Validation
Immutable branch readback confirms the runtime type guard, finite/range checks, NaN-safe aggregate comparison, explicit null/wrong-type regressions, preflight blocking, and a 2-ahead / 0-behind exact-base branch.
Prior focused validation of the narrower issue-body candidate was 10/10; this environment has not executed the new runtime-type regressions, so no fresh full-suite/CI-green claim is made here. Hosted CI should be treated as authoritative for the published head.
Claim / compensation
The assignment and payment request is already live on issue #1012 under
woahwhattheheck. This PR is the implementation carrier for that claimed contribution. Please evaluate it under the issue's applicable reward/bounty process. No award or payment receipt is asserted.